magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.91k stars 782 forks source link

Add in MTGO artid #4147

Closed spjspj closed 6 years ago

spjspj commented 7 years ago

Add an alternate way to render cards based on the 'ArtId' (aka the face-art picture (such as http://mtgoclientdepot.onlinegaming.wizards.com/Graphics/Cards/Pics/161922_typ_reg_sty_050.jpg for example)). This I believe is similar to the way in which modo does it.

Steps: 1) Add the artid into the mtg-cards-data.txt for the artwork of a card in a given set. 2) Code similar card-render logic to how the existing 'new' rendering scheme does it (which currently builds the image based on full scans and then overlaying the M15 card frame over it).
3) Example (https://files.gitter.im/xmage-devs/Lobby/wFt5/sword_of_f_f_investigation3.jpg)

JayDi85 commented 7 years ago

Is that legal? MTGO resources is not available outside MTGO-application.

Look at https://scryfall.com/docs/api/images

They have art_crop param to get art only (they take card's full scan and crop it). Example:

They hint about crop using (use to artist and copyright mark on your custom cards):

art_crop will attempt to isolate the card’s artwork into its own rectangular image file. This will likely not be perfect for outlier card designs. Art crops for different frames and layouts may be different rectangular sizes. As this image is the first where we don’t include the copyright line and artist credit, you are heavily encouraged to show a copyright, disclaimer, and artist credit wherever you display this image.

It's a little bit problem -- Wizards can be angry on xMage: shot_171118_153004

spjspj commented 7 years ago

Is that legal? MTGO resources is not available outside MTGO-application. 1) We're not supplying the actual art at all (people can and do have completely custom images). This was similar to how the old card-tracker generated a custom image.
2) The actual card image you show would be copyright (and as it is and can be custom, who would we give the copyright notification about?). 3) I think the distinction is that xmage didn't supply it to you or for you - you had to go and get it yourself. I'm aware of the cropped images that scryfall has but they aren't full art as for example the Grisela one is if you've been following it on xmage dev chat https://gitter.im/xmage-devs/Lobby. I've got a hybrid scheme going ('cos I like my full art lands to not have a border) on my local client build - https://imgur.com/8rBA33y << May add it as a 'Hybrid M15/Plain Image rendering' option.

spjspj commented 6 years ago

Implemented. (here: https://redd.it/7e0rpg)