magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.91k stars 778 forks source link

Rivals of Ixalan - Card implementation #4328

Closed LevelX2 closed 6 years ago

LevelX2 commented 6 years ago

All Sets

Cards in set:

Zzooouhh commented 6 years ago

Implemented Elenda, the Dusk Rose and Zetalpa, Primal Dawn: #4330 Implemented Etali, Primal Storm: #4337

JayDi85 commented 6 years ago

Scryfall have useful cards order list with actual spoiler data -- no need to search not working google images: https://scryfall.com/sets/rix?order=spoiled

JayDi85 commented 6 years ago

@LevelX2 see Dire Fleet Neckbreaker in your list. It was done already.

JayDi85 commented 6 years ago

BIG Rivals of Ixalan Release Notes:

The Release Notes include information concerning the release of a new Magic: The Gathering set, as well as a collection of clarifications and rulings involving that set's cards. It's intended to make playing with the new cards more fun by clearing up the common misconceptions and confusion inevitably caused by new mechanics and interactions.

https://magic.wizards.com/en/articles/archive/feature/rivals-ixalan-release-notes-2018-01-05

imendi7 commented 6 years ago

Any tutorial where I can learn how to implement cards?

I want to contribute!

LevelX2 commented 6 years ago

Any tutorial where I can learn how to implement cards?

https://github.com/magefree/mage/wiki/Developer-Getting-Started

JayDi85 commented 6 years ago

@imendi7 use developer getting started. Train to setup, build, test and run xmage source code from scratch. After that you can read howto guides (I've added info about card implementation).

JayDi85 commented 6 years ago

@imendi7 try to implement Grasping Scoundrel from new set (I will hold on it until tomorrow -- 24 hours). Use Adanto Vanguard as reference.

imendi7 commented 6 years ago

OK, Ill start working on this now. I am quite a basic programmer, I hope I can deal with this.

Thanks!

JayDi85 commented 6 years ago

@imendi7 you can also contribute to xmage another way -- by testing new or old mechanics and report bugs about it.

imendi7 commented 6 years ago

I've already installed all the stuff. I am going to start now implementing Grasping Scoundrel.

imendi7 commented 6 years ago

I've already implemented the card, but I'm having some troubles with its test. I cannot get to the point where "When the server is running in test mode, a Quick Start button will be available on the Tables screen."

I've added to both "Mage Client" and "Mage Server" the argument "testMode=true", and actually in the "Output - Run (Mage Server)" console I see the text "MAGE server running in test mode", but, still, I cannot see the "Quick Start button". What can I do?

Thanks!

JayDi85 commented 6 years ago

You need only mage server command line. If you see test mode in logs then it's ok. After that go to tables and click here:

shot_180106_231442

shot_180106_231556

P.S. My test.dck in client folder for all tests:

5 [XLN:268] Swamp
5 [XLN:276] Forest
5 [XLN:264] Island
5 [XLN:272] Mountain
5 [XLN:260] Plains

And init.txt file for server config folder:

[init]
battlefield:Human:Forest:5
battlefield:Human:Plains:5
battlefield:Human:Mountain:5
battlefield:Human:Swamp:5
battlefield:Human:Island:5
hand:Human:Lightning Bolt:2

[current test]
hand:Human:Reckless Rage:3
battlefield:Human:Kitesail Corsair:2
battlefield:Computer:Orzaca Frillback:2

[2x bear to me]
battlefield:Human:Orzaca Frillback:2

[2x bear to comp]
battlefield:Computer:Orzaca Frillback:2

[Clone]
hand:Human:Clone:3
imendi7 commented 6 years ago

image

I still don't have the "Quick Start" button.

I see that I am connected to "xmage.de:17171" server and you are to "test2@localhost". Can this be the reason?

Thanks!

JayDi85 commented 6 years ago

Yes, you must connect to your local server.

use commented 6 years ago

Working on:

AricHaldan commented 6 years ago

Hello everyone, I've tried to help implement some cards, but I'm still quite unexperienced and I haven't been able to properly test or find out how I tick the boxes. They're relatively simple cards so they ought to work properly; I've been working on

Brazen Freebooter and Hornswoggle

I think I sent them through git but i'm not sure yet

imendi7 commented 6 years ago

Good morning!

So little by little I'm learning how to deal with the procedure. However, right now I am still stuck at testing step.

I managed to begin a Quick Start game, but when I click on the smiley button I cannot get the Grasping Scoundrel appear on the game. In the NetBeans console I see "WARN 2018-01-07 11:07:01,315 Unknown card [Grasping Scoundrel]: hand:Human:Grasping Scoundrel:1". According to the HOWTO guide "If xmage can't find your card name (see errors log or check it in deck editor) then delete all cards*.db files in developer folder -- it's force to recreate new database;" so I deleted all of them and retried the test but the result is the same. How can I manage this problem?

Thanks!!

JayDi85 commented 6 years ago

@imendi7 check out that things:

imendi7 commented 6 years ago

@JayDi85 Sorry for being so annoying.

I couldn't find my card in the deck editor, so I deleated all the cards*.db files in devs dir. But when I try to run the TEST server, the "Select the Main Class for Execution" window pops up but without any available main classes, so I cannot run the TEST server.

image

JayDi85 commented 6 years ago

@imendi7 no, by "run TEST server" i mean run your local xmage server. But you are try to run xmage tests. Don't do it.

P.S. use devs chat on https://gitter.im/xmage-devs/Lobby