Closed spjspj closed 5 years ago
I updated the to do list
Hello all, newbie here, quick question just to make sure: If I am working on one of the cards not yet done I simply check its box in the second post with In Progress before them, right? In other words, those with unchecked boxes in that post do not have anyone else working on them yet, correct?
In other words, those with unchecked boxes in that post do not have anyone else working on them yet, correct
Yes, correct.
A’ight, thanks.
Sanctum Spirit -- done https://github.com/magefree/mage/pull/4765 (hope I did that right)
Dark Bargain -- done #4766 (again, hope done correctly)
Since I can’t seem to mark the checkboxes here are the cards that I am currently working on: • Gift of Growth • Krosan Druid • Precognition Field
Gift of Growth -- done #4768
Apologies @BrewBrewBrewTheDeck, didn't see.
Stronghold Confessor -- done #4769 Shivan Fire -- done #4770
@rscoates No worries, I am completely new here so if anyone so desires just do the ones I listed. For now I have yet to figure out how to even properly test the cards I did.
@LevelX2 helped me with this earlier but so far we couldn’t determine what went wrong. The issue is that the cards I added showed up in-game (in the deck editor) but had no oracle text when hovering over them. Like, they’re just blank in that area. The cards themselves were fine, I think, but maybe I missed something. If you wanna look over my version of Gift of Growth, for example, this is it:
Level glanced over it and saw nothing out of the ordinary. But perhaps the error lies with the file itself after all and you can spot it. Or know what else might result in that issue. Deleting the cards*.db files and checking the Force Cardbase Update checkbox in the client did not resolve it.
Working on: Run Amok -- done #4771 Healing Grace
Orcish Vandal -- done #4774
Starting on: Curator's Ward - done #4776
Slinn Voda is already done, I just pushed it.
Working on Aryel, Knight of Windgrace maybe, not sure about the power filter
Take a look at Minamo Sightbender and Merchant's Dockhand. It's kinda tricky.
@theelk801 Yes, thank you. Minamo Sightbender was a big help. Not quite there but it's coming together. And Merchant's Dockhand really quite useful for the part I'm on now.
Working on: Radiating Lightning -- done #4777 Weight of Memory -- done #4778
Struggling with Healing Grace. Wording is very specific, guidance for implementing choosing the source to prevent would be really useful.
Done/Need an experienced developer to check: Aryel, Knight of Windgrace PR #4781
I gave it a glance, I'll look into it more soon. If you tested it and it works, it's probably fine, but the main thing to check is whether something like Experiment Kraj or Quicksilver Elemental is able to properly copy its ability.
Working on: Corrosive Ooze -- #4787
I'm on a bad computer with only an IDE, but I think this is right - please test before merging! (Would not normally push, but in the interests of keeping the pace up for DOM, I have).
Working on: Precognition Field -- #4790. Still cannot test, and this card is tricky, but I think it's right. Please test before merging.
Still struggling with Healing Grace, grateful for help / someone to take it on.
I'll do Healing Grace
Thanks @theelk801. Much appreciated.
I realise it's now merged, but it doesn't look like your merge requires you to specify the source of the damage? That was my difficulty, so I appreciate it's hard, but it currently doesn't work as worded.
Firesong and Sunspeaker -- #4792
(Have to leave work, can finish on return home, think it's very close. Not tested.)
Elfhame Druid: https://github.com/magefree/mage/pull/4791
I have some minor fixes to Aryel, Knight of Windgrace PR: #4793 However, I'm very new to this, and the card does not work. I hope that I at least provided a good base to make the work easier.
Fixing up firesong: https://github.com/magefree/mage/pull/4794
I don't know if you guys want this, but here is a list of cards that for various reasons do not show up in the client (in mine anyway). I put stars next to commons and uncommons that are good to great in limited and thus somewhat important for those practicing for prerelease events: 20 Healing Grace 49 Curator’s Ward 50 Deep Freeze 61 Precognition Field 82 Chainer’s Torment 86 Demonlord Belzenlok 101 Rat Colony 108 Torgaar, Famine Incarnate 109 Urgoros, the Empty One 122 The First Eruption 128 Goblin Barrage 131 Haphazard Bombardment 132 Jaya Ballard 141 Seismic Shift 150 Warcry Phoenix 158 Corrosive Ooze 159 Elfhame Druid 167 Krosan Druid 192 Aryel, Knight of Windgrace 193 Darigaaz Reincarnated 195 Grand Warlord Radha 196 Hallar, the Firefletcher 199 Muldrotha, the Gravetide 200 Oath of Teferi 203 Rona, Disciple of Gix 204 Shanna, Sisay’s Legacy 205 Slimefoot, the Stowaway 208 Tiana, Ship’s Caretaker 225 Navigator’s Compass 228 Shield of the Realm 231 Sorcerer’s Wand 275 Chandra, Bold Pyromancer 276 Chandra’s Outburst
@jack-the-BOSS - sure you have, but just in case... have you tried deleting the cards*.db files and/or checking the Force Cardbase Update checkbox in the client? These look like the last few to get finished and it may be a caching issue. I definitely had Jaya Ballard come up for me today, as one I can remember.
@jack-the-BOSS update to latest xmage source code. I'm fixed yesterday some card errors (loading problem). And clean up all db-dirs (client and server) to re-create cards.
@rscoates Good point, not since yesterday.
Hey man, an error happened when trying to do her ultimate. Her emblem crashed when I tried to play any instant or sorcery in my graveyard. Can you help with this? Here's a screenshot:
By the way, everything else works fine with her.
And when do you guys think there’ll be a fix?
@RMFDEMON Alsways read here about content of upcoming fixes: https://github.com/magefree/mage/wiki/Features-and-fixes-not-released-yet Fix will be live with next server restart 8:00 CET
Hey, on the new version it still don't work.
I don't know if it's because if it's fast mana.
Plus in both cases I had at least 1 manamorphose in my graveyard.
Actually it might be because I was also online and there were 2 on the field.
Because it works with 1 on the field I guess.
@RMFDEMON, i tried here, and works fine for me, i using the last version, 1.4.32V0.
All Sets
https://magic.wizards.com/en/products/dominaria
Unimplemented cards
Cards in set: