magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.88k stars 770 forks source link

Freeform commander is not fully implemented (different deck size)? #4696

Open JayDi85 opened 6 years ago

JayDi85 commented 6 years ago

From reddit about current freeform commander restrictions:

I would like to try play-testing Giant Leaders, EDH69 and all those other kind of sub-variants of EDH but the restriction on deck size on the freeform commander forbid the use of most of those. normal freeform doesn't have you start with the general in the command zone and other rules that apply only on EDH.

I can do some coding to change the things I know that are different from the base EDH to the sub-variants but I don't really know how to add those changes as "addons" so they won't interfere with the base game. also a guide for such a thing(making sub-variants as "addons") will make it so that ppl who want to make a new version of the game themself can prototype it in an environment that has rule enforcement so they won't need to worry about how the cards behave when they test it.

it's not really that relevant to the players in the game, just something I thought would be fun to try. and the fact that there are over 10 common variants of EDH, and others that are just played by a small group of friends among themselves - there is no reason at all to include every variation of the format. but if there is a way to allow their use, why not do it?

ruler501 commented 6 years ago

Another common issue that could get lobbed into this is having arbitrary commanders(since many variants and play groups allow planeswalker commanders)

spjspj commented 6 years ago

At the moment, the restrictions on commanders is - any legendary permanent or any creature. There was no formal definition that I found of 'Freeform Commander' when I implemented it so I essentially when 'next-level up' from standard EDH, retaining a quality of normal EDH in freeform EDH. Aka - normally the commander has to be a Legendary Creature, hence the next level (at least to my mind) of this was to retain at least one of those keywords for the commander - that it be Legendary or Creature (or both) (so PWs being legendary can be your commander). There's also very broken combos if you start allowing sorceries/instants as the commander (Channel/hypergenesis etc) comes to mind for example). With the advent of actually legendary sorceries though with Dom, they will be legal.

Dimanari commented 6 years ago

allowing any creature as commander?ohh well, at least not something too weird as you play singleton. the restriction on the legendary side should either be legendary non-land permanent or just creatures and planeswalkers - to match the brawl or go full blown freedom, without resorting to having lands as commander(that would be weird - you NEVER cast them so they'll always come into play for free). but removing the deck-size limit would really be helpful for testing sub-variants in this format, and should prove to be fairly easy in comparison to solving the arbitrary commander issues.

spjspj commented 6 years ago

1) It is precisely because you NEVER cast lands that they're essentially useless as a commander as you can't normally play lands from the command zone.

My other thoughts: 2) My reasons for why you can have any legendary permanent were explained ('next-level' up from a Legendary Creature - so, retaining one half of the links back to the original and best format) 3) I would argue against deck-size limit changes as it's still commander, which has the 99 or 98 main limit. And if you argue for a lesser limit (say 60, or 50), what then is wrong with 59 (or 49)? Or 0 in main? You can call it something else then (as they did with Brawl which is 59 cards + commander or Tiny Leader which is 49 in main).

Dimanari commented 6 years ago

69EDH is a sub variant. and it is common in certain places, also saying that Tiny Leaders and Brawl are essentially different from the base variant is ignoring (from what I counted) more then 10 fairly common sub-variants that have different deck size then the original 100, but I guess that it is just my distorted perspective...

should I list them? and fine I just won't test my 69EDH, modern-Brawl, and so on, in Xmage. it would take me way more time(so many triggers...)