search

magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.8k stars 746 forks source link

Card numbers in mtg-cards-data.txt are wrong #5003

Open theelk801 opened 6 years ago

theelk801 commented 6 years ago

So a lot of the older cards in mtg-cards-data.txt have the wrong numbers, not to mention incorrect oracle text. I'm gonna do a rebuild of the whole file, but I need to make sure I do it correctly and don't remove anything that shouldn't be removed.

Zerrisx commented 3 years ago

Should this be pulled out into a task list so we have a sense of how many more pieces there are to work on for this?

JayDi85 commented 3 years ago

That's file uses for card code generation only and other old perl scripts (I think it uses for set implementation list like #6608 too). And it must be generated from scryfall or mtgjson data source. So there is nothing to fix manually.

xenohedron commented 1 year ago

@theelk801 Is this still relevant and/or planned?

theelk801 commented 1 year ago

It should probably still be done, I've just never gotten around to it because most of the cards it impacts are already implemented