magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.85k stars 762 forks source link

Generic Text Corrections (Part 2) #6654

Open Zerrisx opened 4 years ago

Zerrisx commented 4 years ago

The old thread was getting a bit messy, so I'm transferring all the still-open issues from it to this one, along with a pile of new ones.

From #6465:

New:

Cards misusing "x for each" and/or not using "equal to"

Cards that target twice but shouldn't

Other Issues

ThomasArb commented 4 years ago

As mentioned in #6465, some cards are fixed in MR #6602. The MR was merged few hours ago.

etpalmer63 commented 4 years ago

I got a few of the easy ones fixed: Endless Swarm Collective Restraint Essence Bottle

I will try to knock a few more out before submitting PR.

Thanks @Zerrisx for finding all these.

Edit: Now working on PR #6707

arcox commented 4 years ago

Fix for Choking Vines under #6724

jeffwadsworth commented 4 years ago

Excellent work finding all of these errors.

JayDi85 commented 2 months ago

@xenohedron is it actual list or can be closed? There were many fixes in text generation for paper text equals.

xenohedron commented 2 months ago

Verify test catches all the card text discrepancies, so those aren't needed to be tracked specifically - probably some are fixed and some not yet fixed.

But there are a few items here not covered by verify test, more to do with GUI text display, need to confirm whether still actual: