search

magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.85k stars 761 forks source link

Wrong file line endings for run scripts (need to upgrade build script) #6805

Open Dragas opened 4 years ago

Dragas commented 4 years ago

Shell scripts in the launcher directory for both server and the client contain windows based line endings rather than unix ones, as a result, causing the shell scripts to fail to start up due to

bash: ./startClient.sh: /bin/sh^M: bad interpreter: No such file or directory

Workaround for this is to run the file through dos2unix utility. Consider fixing this at repository level by changing the file line endings from windows to unix for bash script files.

Zerrisx commented 4 years ago

Fixed by f517406

JayDi85 commented 4 years ago

The real reason: I builds distribution files on Windows system so the git automaticity replace line endings to system dependents (use CRLF after download and use LF before upload).

So the real fix: add dos2unix step to build script.

OliTat commented 1 year ago

This issue still seems to happen on 1.4.52-v4-beta7. Is this still active?