magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.9k stars 774 forks source link

stop hitting yourself: a quick review of the code of some cards #6844

Open copperfield42 opened 4 years ago

copperfield42 commented 4 years ago

In light of the issue #6838 I searched for a bunch of cards that are somewhat similar to Beast Within and then look into their code looking for their outcome constants, if any, to see if there are other that might need similar treatment as the aforementioned card, and the following are the cards I found:

For Assassin's Strike and Desecrated Earth the outcome said its draw a card, but it should be discard

Bomb Squad: Maybe? I don't know what part of it the AI use to select targets, but you don't want to put those counters on your stuff... usually

Glissa's Scorn: If I understand the code correctly, is market as it prevent regeneration, but that is not the case with this card.

And finally for this last few I'm not sure or is debatable I guess: Nature's Claim Descent of the Dragons Ob Nixilis, the Hate-Twisted Ghost Quarter (I actually like its current behavior, but I included it here for completeness)

JayDi85 commented 4 years ago

BTW, outcome status (bad or good) uses for target, not controller/chooser. Example:

So if controller must choose permanents for damage -- it's good for him, but outcome must be bad (cause target gets bad effect). Thats the most popular error in outcome setup.

copperfield42 commented 4 years ago

I continued looking into some other cards, this time into Song of the Dryaid/Pacifism style cards, and this are the one I found:

Vow of Wildness: the only one the Vow of cycle marked as detrimental.

Bonds of Faith: is conditionally good or bad

The following either grand a bonus with a downside or downside you can transform into a bonus, so is debatable I guess:

Chained to the Rocks: I'm no sure what to think of this one

copperfield42 commented 4 years ago

I continued with some more auras:

Curses and cards that remove abilities:

Unboost cards:

Cards that are +x/-y, so I guess it depends on the -y:

copperfield42 commented 4 years ago

I continued with some other cards, counterspell edition:

Also the other day playing with the AI, saw the AI Swan Song its own card card and Pongify its own creature.

Bonus mills cards: