search

magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.91k stars 780 forks source link

Rollbacks leave visual clutter for cards in exile #6856

Open Zerrisx opened 4 years ago

Zerrisx commented 4 years ago

If you exile a card, then roll back, the visual of the card in exile remains, even if - as far as I can tell - the card itself returns to the correct location.

Example: exile a card with shelldock isle, then roll back. It still looks like you have a card exiled face down, but you can no longer look at it (because the real card isn't there any more).

If relevant, I was doing this in the test framework - so after the rollback, the Shelldock Isle itself no longer existed at all.

image

JayDi85 commented 4 years ago

Try click on any avatar -- it will call full game update. Is it still there or disappeared?

Zerrisx commented 4 years ago

Still there - here's a face down card for the shelldock isle that was rolled back into my hand. Remains unchanged after clicking on either players avatar.

image

jeffwadsworth commented 4 years ago

Some cards do exile cards correctly...the exiled cards do get cleared on a rollback. Path to Exile and Archon of Justice, for example, work correctly with rollback. Oblivion Ring does not.

jeffwadsworth commented 4 years ago

If an exile uses an "exileId", the card will not be removed from the Exile Zone following a rollback in the GUI. In the gamestate, it is removed.