magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.86k stars 761 forks source link

ZNR Functional Bugs #7046

Open Zerrisx opened 4 years ago

Zerrisx commented 4 years ago

Current up to the implementation of Akiri, Fearless Voyager.

Verified Fixed:

- [x] Akiri, Fearless Voyager - doesn't unattach equipment when activating ability. ![image](https://user-images.githubusercontent.com/59861365/93272776-ec8e2c80-f77b-11ea-9ada-cf38d2bcfa25.png) - [x] Akiri, Fearless Voyager - doesn't draw a card when an equipped creature attacks. ![image](https://user-images.githubusercontent.com/59861365/93273058-8b1a8d80-f77c-11ea-9438-268554d8d600.png) - [x] Akiri, Fearless Voyager - the ability should be a may (currently, if you have any attached equipment, you must choose one) - [x] Allied Assault - only lets you target one creature ![image](https://user-images.githubusercontent.com/59861365/93272181-8bb22480-f77a-11ea-9fe8-19359d8a24d5.png) - [x] Play Ashara, Soul of the Wild, then another creature (which is now a forest land), and then enchant Ashara with Kenirith's Transformation. Thanks to the magic of layers, Ashara should lose her abilities, but the type changing effect will still be active. As a result: 1) Ashaya should have no text. This is working correctly. 2) All other creatures should remain forest lands. This is working correctly. 3) Further creatures entering the battlefield will also still be forest lands and trigger landfall. This is working correctly. 4) Ashaya herself should still be a forest land - this is working correctly. 5) Other creatures should still be able to tap for G - ***this is not working correctly***. ![image](https://user-images.githubusercontent.com/59861365/92333044-e2678200-f047-11ea-9f26-08430595a91e.png) - [x] Blood Price - doesn't make you lose two life ![image](https://user-images.githubusercontent.com/59861365/93271650-67a21380-f779-11ea-9acc-d381eab8f12a.png) - [x] Crawling Barrens - if you activate the ability and choose to have it become a creature more than once, it starts duplicating types. ![image](https://user-images.githubusercontent.com/59861365/92934167-caf41480-f40c-11ea-9f3b-e65b51bca13c.png) - [x] Drana, the Last Bloodchief - triggers when attacking, but the AI doesn't choose a creature to return from my graveyard, so the trigger doesn't do anything. ![image](https://user-images.githubusercontent.com/59861365/93273378-51965200-f77d-11ea-81cc-ab479f8c3772.png) - [x] Drana, the Last Bloodchief - doesn't cause the creature to become a vampire ![image](https://user-images.githubusercontent.com/59861365/93540084-37dd4200-f918-11ea-8496-d1de76b7159b.png) - [x] Feed the Swarm - Targets any enchantment (and no creatures), instead of an opponent's creature or enchantment. ![image](https://user-images.githubusercontent.com/59861365/92334895-b5bb6680-f057-11ea-8d98-e813778a60dc.png) - [x] Glacial Grasp - completely missing the target part of the card. Nothing gets tapped (and therefor nobody mills). It draws a card and does nothing else. ![image](https://user-images.githubusercontent.com/59861365/92937973-9cc50380-f411-11ea-990c-9c2a8cf743c5.png) - [x] Glasspool Mimic// - entering as a copy of a creature should be *optional* - i.e. you can just let it be a 0/0 and die if you want - but currently you're forced to pick. - [x] Goma Fada Vanguard - should have a hint for how many Warriors you control ![image](https://user-images.githubusercontent.com/59861365/92334813-f070cf00-f056-11ea-9423-341283342fc6.png) - [x] Grakmaw, Skyclave Ravager - the token created by the death trigger dies immediately; it's likely being created as a 0/0. ![image](https://user-images.githubusercontent.com/59861365/93275340-4560c380-f782-11ea-9809-9ec869a46d3e.png) - [x] Inscription of Abundance, Insight, and Ruin have their kicker coded incorrectly. It goes as such: 1) It asks you to make a choice of which option you want 2) It asks if you want to pay kicker *(this should have happened first!)* 3) Even if you chose to pay kicker, you get no additional options, and the spell casts with a single mode 4) But if you cancel or roll back to the start of the turn *after* choosing to kick but *before* paying, now you can pick all three modes... again before choosing whether or not to pay kicker 5) At which point, you can choose to not pay kicker but still resolve all three modes. Here's a picture of all three modes being cast, without paying kicker: ![image](https://user-images.githubusercontent.com/59861365/92934757-7ac98200-f40d-11ea-8acf-83a59a015e36.png) - [x] Jace, Mirror Mage - if you cast him with kicker, his token dies immediately. Looks like it's probably not getting the loyalty counter it should. ![image](https://user-images.githubusercontent.com/59861365/92334698-1cd81b80-f056-11ea-86b4-8d593e2699fd.png) - [x] Kargan Intimidator - the first option (get +1/+1) is missing from the mode selection, although the AI can still pick it. ![image](https://user-images.githubusercontent.com/59861365/92971339-e6c7dc80-f445-11ea-890c-08bc0edfb0e7.png) - [x] Kargan Intimidator - rather than not being able to choose the same mode for the rest of the turn, it appears you are not able to choose the same mode *ever again*. - [x] Kaza, Roil Chaser - should have a hint for how many Wizards you control ![image](https://user-images.githubusercontent.com/59861365/92336641-5a45a480-f068-11ea-98f9-1c29a9eb83d6.png) - [x] Kazandu Mammoth// - should get +2/+2 per landfall instead of +1/+1 ![image](https://user-images.githubusercontent.com/59861365/93531788-6aca0a80-f905-11ea-8b2f-86d9006550b2.png) - [x] Leyline Tyrant - regardless of what you select for X on death, it doesn't ask you to pay any mana and deals 0 damage ![image](https://user-images.githubusercontent.com/59861365/93273830-7b9c4400-f77e-11ea-97b7-aa218ddb17f6.png) - [x] Linvala, Shield of Sea Gate - her target is missing the hint text "Can't use activated abilities" ![image](https://user-images.githubusercontent.com/59861365/92336988-e4433c80-f06b-11ea-8ed2-468a0d2d0368.png) For comparison: ![image](https://user-images.githubusercontent.com/59861365/92336997-f8873980-f06b-11ea-8ccc-0e37f0f5bf34.png) - [x] Maddening Cacophony - currently mills half rounded *down* with kicker, should mill half rounded *up* ![image](https://user-images.githubusercontent.com/59861365/92972743-5f2f9d00-f448-11ea-8f7e-f4b02145346b.png) - [x] Magmatic Channeler - should have a hint for how many instants/sorceries are in your graveyard ![image](https://user-images.githubusercontent.com/59861365/92972790-7cfd0200-f448-11ea-8450-4b28d40b5e2c.png) - [x] Malakir Rebirth// - doesn't target anything, so it loses you two life and has no other effects. ![image](https://user-images.githubusercontent.com/59861365/93531203-71a44d80-f904-11ea-98a9-ba5ffd69523d.png) - [x] Molten Blast - the first ability is wrong, both in text *and* effect. ![image](https://user-images.githubusercontent.com/59861365/92634286-adeb0480-f299-11ea-8729-2de67fa3dbca.png) ![image](https://user-images.githubusercontent.com/59861365/92947877-34c8ea00-f41e-11ea-9014-9414d7de1cef.png) - [x] Moraug, Fury of Akoum - always puts the extra attack phase after the *second* main phase, even if you play your land in first main. ![image](https://user-images.githubusercontent.com/59861365/93274359-cbc7d600-f77f-11ea-8a7d-8b712a066c6b.png) - [x] Moraug, Fury of Akoum - is giving an extra post-combat main phase, which it shouldn't - you only get extra combat phases. ![image](https://user-images.githubusercontent.com/59861365/93540730-3280f700-f91a-11ea-977b-33cccb8a69ea.png) - [x] Moraug, Fury of Akoum - only gave me one extra combat phase after playing two lands. ![image](https://user-images.githubusercontent.com/59861365/93540806-65c38600-f91a-11ea-9bda-d1ab24484ee9.png) ![image](https://user-images.githubusercontent.com/59861365/93540829-74aa3880-f91a-11ea-9915-600e830b5bf4.png) ![image](https://user-images.githubusercontent.com/59861365/93540863-93a8ca80-f91a-11ea-94cc-e77c7925a8f3.png) - [x] Moraug, Fury of Akoum - if you play a land in first main, the extra combat should come *before* your regular combat step (relevant to determine when creatures get untapped) ![image](https://user-images.githubusercontent.com/59861365/93942100-5dda5c00-fcf5-11ea-8561-096b9bc7ec83.png) - [x] Moraug, Fury of Akoum - if you play a land in second main, you don't get an extra combat step after it ![image](https://user-images.githubusercontent.com/59861365/93941942-0936e100-fcf5-11ea-9b3e-4ad2e53ebc5e.png) - [x] Nahiri, Heir of the Ancients - her +1 has no text ![image](https://user-images.githubusercontent.com/59861365/92337340-7d735280-f06e-11ea-87c0-94a6440e01e0.png) - [x] Nahiri, Heir of the Ancients - her +1 doesn't resolve properly (it doesn't let you attach an equipment to the token) - [x] Nimble Trapfinder - the full party text gets applied to *all* permanents, not just creatures. ![image](https://user-images.githubusercontent.com/59861365/93276570-873f3900-f785-11ea-951f-73d26468c9cb.png) - [x] Nimble Trapfinder - the hint doesn't track properly when in the hand ![image](https://user-images.githubusercontent.com/59861365/93275753-5bbb4f00-f783-11ea-9fea-af8ca5a31b76.png) - [x] Nimble Trapfinder - rules text shows an error in the hand ![image](https://user-images.githubusercontent.com/59861365/93540159-6e1ac180-f918-11ea-89dd-d0de68414c0b.png) - [x] Nissa of Shadowed Boughs - doesn't have her +1. ![image](https://user-images.githubusercontent.com/59861365/93274040-f7968c00-f77e-11ea-9f24-8b3dfc91c713.png) - [x] Nissa of Shadowed Boughs - says "a card" on one screen where it should say creature. ![image](https://user-images.githubusercontent.com/59861365/93275195-e00cd280-f781-11ea-868f-d1306b201b1a.png) - [x] Nissa of Shadowed Boughs - her -5 lets you pick any card type, not just creatures. ![image](https://user-images.githubusercontent.com/59861365/93415625-913a6800-f869-11ea-9d9a-35f2565941fd.png) ![image](https://user-images.githubusercontent.com/59861365/93274498-1c3f3380-f780-11ea-8f3b-668f807bd4e1.png) - [x] Resolute Strike - if you choose an equipment, it gets unequipped from the creature it's currently attached to, but does *not* get attached to the target of Resolute Strike. ![image](https://user-images.githubusercontent.com/59861365/92974313-876ccb00-f44b-11ea-80e9-9721595c1c34.png) - [x] Resolute Strike - the equipment half should be a may; it currently *forces* you to choose an equipment if you own one. - [x] Scourge of the Skyclaves - the kicker doesn't trigger or do anything. - [x] Scute Swarm still makes an Insect token, even with 26 lands in play ![image](https://user-images.githubusercontent.com/59861365/92973753-6a83c800-f44a-11ea-99b3-b358230a173e.png) - [x] Sizzling Barrage - the target restrictions on this spell are flawed in some way - you can cast it on any creature with summoning sickness, and creatures that have attacked - but *not* creatures that have blocked. ![image](https://user-images.githubusercontent.com/59861365/92975685-6ce82100-f44e-11ea-9b88-b2dc29779fe4.png) ![image](https://user-images.githubusercontent.com/59861365/92975789-b5074380-f44e-11ea-8af1-ff14b884f16c.png) - [x] Skyclave Apparition - if you Unsummon or Lightning Bolt it in response to the exile trigger, it throws a rollback error. ![image](https://user-images.githubusercontent.com/59861365/93280332-fff6c300-f78e-11ea-8b8f-afa256f98652.png) - [x] Spikefield Hazard// - should exile the permanent if it dies this turn ![image](https://user-images.githubusercontent.com/59861365/93532704-28093200-f907-11ea-8194-86e3cf8180e1.png) - [x] Strength of Solidarity - still puts one +1/+1 counter on the target when you have 0 party members, which it should not. ![image](https://user-images.githubusercontent.com/59861365/92978006-272e5700-f454-11ea-92ab-386fc5df306e.png) - [x] Taborax, Hope's Demise - the entire "if it was a Cleric" rider on the death trigger isn't being checked; you don't get the option to draw a card. ![image](https://user-images.githubusercontent.com/59861365/93279095-ff106200-f78b-11ea-8459-57210776b1cb.png) - [x] Tajuru Paragon - if cast with kicker, throws a rollback error on resolution ![image](https://user-images.githubusercontent.com/59861365/92978250-e7b43a80-f454-11ea-8297-905d2a86d6ce.png) - [x] Thieving Skydiver - stealing an equipment isn't attaching it to the skydiver ![image](https://user-images.githubusercontent.com/59861365/93277991-05510f00-f789-11ea-9702-21d38429a98f.png) - [x] Thieving Skydiver - shouldn't allow X to be 0, which it currently does. - [x] Throne of Makindi - is adding three mana for kicker spells, when it should only add two. ![image](https://user-images.githubusercontent.com/59861365/93279256-71814200-f78c-11ea-8427-2561ed89ed07.png) - [x] Valakut Exploration - the end step trigger to put the exiled cards into the graveyard and deal damage isn't triggering ![image](https://user-images.githubusercontent.com/59861365/93279950-236d3e00-f78e-11ea-88eb-61623bc588b0.png) - [x] Vine Gecko - the kicker discount isn't applying ![image](https://user-images.githubusercontent.com/59861365/93277165-3defe900-f787-11ea-92a5-818fa34a09a8.png) - [x] Yasharn, Implacable Earth - the lands found are not revealed, at least not in the chat log. ![image](https://user-images.githubusercontent.com/59861365/92978874-aa50ac80-f456-11ea-83f6-8b3e5a3c2d53.png) For comparison: ![image](https://user-images.githubusercontent.com/59861365/92978901-c0f70380-f456-11ea-8752-33ba97ac1541.png) - [x] Yasharn, Implacable Earth - should find one forest and one plains, but you can currently choose to find two of the same land instead. ![image](https://user-images.githubusercontent.com/59861365/92978583-d0c21800-f455-11ea-95d9-6676b6bbd47f.png) - [x] Yasharn, Implacable Earth - only prevents paying life or sacrifice creatures; should prevent sacrificing any non-land permanents to cast spells or activate abilities. ![image](https://user-images.githubusercontent.com/59861365/93291642-40fbd100-f7a9-11ea-84ec-bcee092c3411.png) - [x] Zagras, Thief of Heartbeats - in a human vs AI game, the game freezes when a creature attacks a planeswalker with Zagras in play. Looks like it freezes exactly when it tries to calculate damage. Had this happen four times in a row, so it's pretty easy to reproduce. ![image](https://user-images.githubusercontent.com/59861365/93278472-62999000-f78a-11ea-9a39-6ebd1cca3647.png) - [x] Zareth San, the Trickster - the on-damage trigger incorrectly claims you need to pick a *nonland* permanent ![image](https://user-images.githubusercontent.com/59861365/93279783-b8bc0280-f78d-11ea-98f5-82ccd81f66f1.png)
theelk801 commented 4 years ago

Everything is fixed except the unblockable hints, not sure how to do those but @JayDi85 probably does