search

magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.8k stars 749 forks source link

suggestion for the ability/keyword icons #7471

Open copperfield42 opened 3 years ago

copperfield42 commented 3 years ago

Loving those ability icons, the one for trample is hilarious, and fitting if you're in the receiving end of some enormous trample creature XD 008 avilities icon 6 wrong spelling but as show above is misspelled.

Now for reason I open this issue: 008 avilities icon 5 008 avilities icon

I don't think that using the symbols for man and gay man respectively are appropriate for the abilities of first and double strike.

Something with swords I think is better, like the one already used for the attack phase

image

or those emojis maybe: 🗡️ ⚔️ https://emojipedia.org/dagger/ https://emojipedia.org/crossed-swords/

the one for indestructible 008 avilities icon 4 I don't like it much either, because it remind me of the yugioh card Monster Reborn which is a reanimation spell, and that symbol, the Ankh, is a symbol for life, so it might be better for something like persist or undying, so for this one I suggests something with a shield instead.

like this emoji maybe: 🛡️ https://emojipedia.org/shield/

copperfield42 commented 3 years ago

008 avilities icon 7 looking at the infect icon, it does not strike my as appropriate given that the motif for it is more of a plague than chemistry

maybe the virus emoji: 🦠 https://emojipedia.org/microbe/ in particular the openmoji version openmoji

But I suppose that that could be inappropriate give the current situation, so how about the set symbol for New Phyrexia or the phyrexia mana that already are in the symbols folder

NPH-C BP

JayDi85 commented 3 years ago

New Phyrexia symbol can't be used cause it depends on wizards images and is optional to download. All card icons are open source and packed with the app all time, so it must use open source and free license.

Also all icons must use solid black/white style without other colors (but I can edit it, e.g. make it black). There are another requirements for icon files:

You can find all used icons in that folder (github can show it):

Ability related icons and file names can be found here:

copperfield42 commented 3 years ago

alright, how about those:

for infect one of those: https://fontawesome.com/icons/disease?style=solid https://fontawesome.com/icons/virus?style=solid https://fontawesome.com/icons/biohazard?style=solid https://fontawesome.com/icons/dizzy?style=solid (for a little hilarity like with trample one XD) https://fontawesome.com/icons/skull?style=solid

for indestructible one of those: https://fontawesome.com/icons/shield-alt?style=solid https://icons.getbootstrap.com/icons/shield-fill-x/ https://icons.getbootstrap.com/icons/shield-x/ https://icons.getbootstrap.com/icons/shield-shaded/

for first and double strike: https://pixabay.com/vectors/duel-saber-sword-1294350/ https://pixabay.com/vectors/swords-crossed-medieval-old-knight-310788/ https://pixabay.com/vectors/swords-crossed-black-silhouette-311733/

And it should be easy to remove one of the swords to use as the first strike one.

It appear that the symbol used for vigilance, the Khanda, is used in some religion or something from Arabic people, so maybe is better to change it too, so how about any of those https://fontawesome.com/icons/street-view?style=solid https://fontawesome.com/icons/eye?style=solid (which look like the eye already used in the vigilance counter) https://fontawesome.com/icons/user-shield?style=solid

copperfield42 commented 3 years ago

here some other suggestions for other keywords:

Reach: https://pixabay.com/vectors/bow-arrow-shaft-bolt-weapon-sport-307275/ https://pixabay.com/vectors/arrow-bow-heraldic-heraldry-149273/ https://pixabay.com/vectors/bow-arrow-drawn-archery-target-311747/

Shroud: https://fontawesome.com/icons/unlock-alt?style=solid https://fontawesome.com/icons/expeditedssl?style=brands https://fontawesome.com/icons/keycdn?style=brands https://fontawesome.com/icons/user-lock?style=solid

JayDi85 commented 3 years ago
copperfield42 commented 3 years ago

cool. 😮 I didn't know that the svg format looking like that internally

Infect can't be virus icon due covid-19. Maybe in the future it can be replaced by radiation icon.

alright, but that one wasn't my only suggestion for icon tho... the radiation one sound fine too

leemi commented 3 years ago

Would it be possible to use the icons from https://github.com/andrewgioia/Mana ? The font itself is open sourced, but the symbols are the same as WOTC's, so just checking. If this isn't a problem, I can gladly look into creating a PR.

JayDi85 commented 3 years ago

@leemi for what purposes?

  1. XMage can't distribute copyrighted data, so it must be optional (e.g. downloadable from third party web sites);
  2. Java's GUI (swing) is limited and doesn't support CSS (e.g. you can't use css in game chats, only direct font or images);
  3. There are some working code with svg transformations and css for mana icons generation (svg files are downloadable from scryfall).
leemi commented 3 years ago

  1. The Mana font itself is distributed with a SIL OFL 1.1 license, which does allow it to be freely packaged. But I just wanted to double check for other legalities you're looking out for. On the other hand, I do notice the PW symbol is an embedded image in the deck editor. image

  2. It does provide SVGs, as well.

  3. Correct me if I'm wrong, but I don't see a way to download things like: ability symbols image or card type symbols image

thefnitalian commented 3 years ago

For Infect, couldn’t you use the phyrexian symbol since it is closely tied with that block similar to the ankh for gods?

alexander-novo commented 1 year ago

here some other suggestions for other keywords:

Reach: https://pixabay.com/vectors/bow-arrow-shaft-bolt-weapon-sport-307275/ https://pixabay.com/vectors/arrow-bow-heraldic-heraldry-149273/ https://pixabay.com/vectors/bow-arrow-drawn-archery-target-311747/

Shroud: https://fontawesome.com/icons/unlock-alt?style=solid https://fontawesome.com/icons/expeditedssl?style=brands https://fontawesome.com/icons/keycdn?style=brands https://fontawesome.com/icons/user-lock?style=solid

I tried out some of these reach ones and they're just too small imo

image

alexander-novo commented 1 year ago

image

I think this one isn't so bad 😂. Starting a petition for a toggle in settings to rename reach "uppies"

copperfield42 commented 1 year ago

here some other suggestions for other keywords: Reach: https://pixabay.com/vectors/bow-arrow-shaft-bolt-weapon-sport-307275/ https://pixabay.com/vectors/arrow-bow-heraldic-heraldry-149273/ https://pixabay.com/vectors/bow-arrow-drawn-archery-target-311747/ Shroud: https://fontawesome.com/icons/unlock-alt?style=solid https://fontawesome.com/icons/expeditedssl?style=brands https://fontawesome.com/icons/keycdn?style=brands https://fontawesome.com/icons/user-lock?style=solid

I tried out some of these reach ones and they're just too small imo

image

then, how about those:

with an archer motif https://pixabay.com/vectors/archer-woman-female-bow-warrior-7166439/ https://pixabay.com/vectors/archer-archery-bow-and-arrow-sports-35508/ https://pixabay.com/vectors/woman-artemis-arrow-bow-fantasy-3663111/

or with a spider motif https://pixabay.com/vectors/spider-web-cobweb-black-gray-art-308518/ https://pixabay.com/vectors/cobweb-spider-web-black-silhouette-311734/ https://pixabay.com/vectors/spider-silhouette-halloween-2769985/

alexander-novo commented 1 year ago

The "uppies" icon was already merged in. All of those archer motifs have too much going on with too thin of strokes for such a small icon.