search

magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.86k stars 761 forks source link

The UI is allowing me to look at opponent's foretell cards #7640

Open foryayfan opened 3 years ago

foryayfan commented 3 years ago

I was testing a deck against the AI opponent. The AI opponent put several cards in exile as foretell cards. The UI opens a window for each foretold card. I can click on the cards in those windows and it reveals the name of the cards that the opponent has foretold. A player should not be able to see the card names of the opponents foretold cards. java_4DFNcmgprL

jeffwadsworth commented 3 years ago

Just confirmed this issue. It was working fine after the fix. I will look at it again to see what changed. https://github.com/magefree/mage/issues/7596

foryayfan commented 3 years ago

Yes I am using the latest client. Yes I could view the face of the card. I can provide one additional detail: those cards were foretold using the Dream Devourer ability. Perhaps that is why I was allowed to view the card face.

Get Outlook for Androidhttps://aka.ms/ghei36

From: Jeff Wadsworth notifications@github.com Sent: Wednesday, March 3, 2021 10:49:20 PM To: magefree/mage mage@noreply.github.com Cc: foryayfan happy.sanders@hotmail.com; Author author@noreply.github.com Subject: Re: [magefree/mage] The UI is allowing me to look at opponent's foretell cards (#7640)

Are you trying this with the latest client? Also, did you actually click the "Yes, look at the card" and see the card? Your picture just shows the option.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmagefree%2Fmage%2Fissues%2F7640%23issuecomment-789767475&data=04%7C01%7C%7C548b5d8435ac4ae24d8708d8de5387b9%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637503797625359736%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=6OmwhoWG%2Fq9iCjnCG74pVd319IFhKCMlUyzPLrsiFUE%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAR7KBZUGCR7LLT6WEDA3CJLTBZD7BANCNFSM4YQ7KCZA&data=04%7C01%7C%7C548b5d8435ac4ae24d8708d8de5387b9%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637503797625369729%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=bj%2Bbf7AmWgZ6ajHlVJ7gCBoe6Q7mKNUQW36rtDV8on8%3D&reserved=0.

jeffwadsworth commented 3 years ago

The controller of the source ability (the Foretold Special Ability) is being changed to the current priority player now for some reason. Thus, when it checks the permission, it is allowed to view the card in exile.

jeffwadsworth commented 2 years ago

This appears to be working correctly now. Please open again if it resurfaces.

xenohedron commented 8 months ago

reported again today in a REMA draft: "bug with foretell card - I was able to look at opponents card. I also had the button to cast it - but that did nothing"

"Even has my name on it - not opponents" image