Deck import from clipboard uses txt format and ignores set information

magefree / mage

Magic Another Game Engine

http://xmage.today

MIT License

1.84k stars 756 forks source link

Deck import from clipboard uses txt format and ignores set information #7665

Open ldeluigi opened 3 years ago

ldeluigi commented 3 years ago

Import from clipboard dialog could/should interpret codes for preferred card sets, eaither by:

Changing how the txt interpreter works to allow specifying the set for a card:
https://github.com/magefree/mage/blob/b51915f6e8a9fce8ca3651dbc6f341e97a07dc76/Mage/src/main/java/mage/cards/decks/importer/TxtDeckImporter.java#L129
Allowing to select a format for cards (without forcing the .txt interpreter) in the Import Deck from Clipboard dialog, for example with a dropdown menu
Automatically detect the format of the pasted text to select the best interpreter

JayDi85 commented 3 years ago

Sets (card images) must be changed/replaced after import by GUI. I can't find related Deck Editor topic (but I known there are must be). Look at current GUI button to change selected cards to oldest version. Also you can look at #7182 to find some ideas about card replacement use cases.

JayDi85 commented 3 years ago

Argh, I've got that are you talking about. Yes, combobox can be useful.

Separate features:

Import code: auto-recognize deck format from clipboard text (it's must be simple check for first line, use case: pasted text from mtga app);
Clipboard dialog: combobox with preferred set or sets list (formats) for imported text;
Deck editor buttons: replace selected cards from one set to another.