magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.87k stars 764 forks source link

GUI: add booster collation settings to tourney's cubes #8079

Open T-a-n-d-E-m opened 3 years ago

T-a-n-d-E-m commented 3 years ago

See comments below for details about booster collation settings

...

When choosing the set(s) for a draft or sealed tournament it would be great if we could choose sets of our own creation similar to how 'Cube From Deck' allows loading a custom cube. A custom set would be a simple text file containing a list of cards and their rarity in the set. Perhaps something like this:

NAME: Ice Age Remastered
DESC: Custom set using cards from Ice Age, Alliances, Coldsnap, Future Sight, Modern Horizons and Kaldheim
OPTS:
include_basic_lands=false
lands=1 # if include_basic_lands is false and this is > 0, choose a land from the card list below
commons=10
uncommons=3
rare=1
mythic_ratio=7.5

CARDS:
# rarity [set:num] name
C [ME2:245] Snow-Covered Forest
C [ICE:100] Snow Devil
U [CSP:123] Sound the Call
U [MH1:194] Abominable Treefolk
...

When generating booster packs the rarity of the card specified in the custom set file would be used, not the rarity the card has printed on it. For example, in the custom set above the card Sound the Call has been shifted up from a common to an uncommon.

Bonus effect of implementing this feature: Whenever an official 'remastered' set is completely spoiled the XMage community could implement it as a custom set while waiting for a new XMage release to include it.

JayDi85 commented 3 years ago

There are custom cube from the deck (you can use any cards for your tourney and it will be put with boosters). But it uses different booster logic (puts cards to booster at random order, so rarity ratio can be different).

shot_210731_095828

T-a-n-d-E-m commented 3 years ago

There are custom cube from the deck (you can use any cards for your tourney and it will be put with boosters). But it uses different booster logic (puts cards to booster at random order, so rarity ratio can be different).

shot_210731_095828

I believe the booster logic for sets is different enough from cubes for this to justify it's own request.

JayDi85 commented 3 years ago

I believe the booster logic for sets is different enough from cubes for this to justify it's own request.

You can create any request or question. Current request is overdeveloped and duplicates another features.

Problems:

If you remove custom rarity then it will be... Cube from Deck. Already workable, with deck editor and game modes support.

T-a-n-d-E-m commented 3 years ago

You're right - If people can't use a GUI of some kind to create the custom sets it would likely not get used...

* duplicated features from "Cube from Deck" mode (95% are same).

It's that 5% difference that matters. Would it be too much to add a selector to the New Tourney dialog to choose between cube collation and set collation? Something like this: image

This would control how the server generates the packs. Ideally choosing set collation would pop up another dialog to customize the ratio of rarities, but if that's too much just use the standard 1 land, 10 commons, 3 uncommons, 1 rare.

This method wouldn't support custom rarities, that can come at a later time! 😁

JayDi85 commented 3 years ago

Collation methods for cube can be implemented:

T-a-n-d-E-m commented 3 years ago

Collation methods for cube can be implemented:

* Random 15 (current);

* Standard rarity slots (xmage will split a cube cards by rarity and fill each booster due rarity slots);

That would be fantastic! Thank you!! πŸ‘

theelk801 commented 3 years ago

I have some unfinished code for a color-based collation method that I've been meaning to finish