search

magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.88k stars 770 forks source link

Cumulative Upkeep Improvement #9221

Open Alex-Vasile opened 2 years ago

Alex-Vasile commented 2 years ago
  1. You are still asked if you want to pay the cumulative upkeep even if you cannot afford it.
  2. The mana amount is not being condensed. This should be {2} instead of {1}{1}: upkeep
PurpleCrowbar commented 2 years ago

Would a hypothetical fix to point 1 consider only permanents that generate mana and the sum of possible mana generated by said permanents or would it also consider the effects of spells in hand which generate mana such as [[Dark Ritual]]? Seems like it may be a necessary inconvenience

github-actions[bot] commented 2 years ago

Dark Ritual - (Gatherer) (Scryfall) (EDHREC)

{B} Instant Add {B}{B}{B}.

Alex-Vasile commented 2 years ago

Would a hypothetical fix to point 1 consider only permanents that generate mana and the sum of possible mana generated by said permanents or would it also consider the effects of spells in hand which generate mana such as [[Dark Ritual]]? Seems like it may be a necessary inconvenience

I am not sure how the game currently calculates if a spell is castable (I.e. highlighted). I don't remember if it can take something like that into account.

See for example the leftover points in #6698.

Perhaps it cannot.

github-actions[bot] commented 2 years ago

Dark Ritual - (Gatherer) (Scryfall) (EDHREC)

{B} Instant Add {B}{B}{B}.