search

magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.85k stars 762 forks source link

If have creatures that grant abilities (Frondland Felidar, Jubilant Skybonder, Proud Wildbonder), the third one you cast will cause both the first two to lose their abilities. The fourth one cast will cause the third to lose its ability. #9565

Open Alex-Vasile opened 1 year ago

Alex-Vasile commented 1 year ago

If have creatures that grant abilities (Frondland Felidar, Jubilant Skybonder, Proud Wildbonder), the third one you cast will cause both the first two to lose their abilities. The fourth one cast will cause the third to lose its ability. image image

Alex-Vasile commented 1 year ago

May be related to #8007

Since all three gainAbility effects use effect.setDependedToType(DependencyType.AddingAbility);. Now each of them are supposed to care about the gaining of the ability related to their effect (Jubilant Skybonder cares about Flying). But it looks like they're interfering with each other.

Alex-Vasile commented 1 year ago

[[Frondland Felidar]], [[Jubilant Skybonder]], [[Proud Wildbonder]]

github-actions[bot] commented 1 year ago

Frondland Felidar - (Gatherer) (Scryfall) (EDHREC)

{2}{G}{W} Creature — Cat Beast 3/5 Vigilance Creatures you control with vigilance have "{1}, {T}: Tap target creature."

Jubilant Skybonder - (Gatherer) (Scryfall) (EDHREC)

{1}{W/U}{W/U} Creature — Human Wizard 2/2 Flying Creatures you control with flying have "Spells your opponents cast that target this creature cost {2} more to cast."

Proud Wildbonder - (Gatherer) (Scryfall) (EDHREC)

{2}{R/G}{R/G} Creature — Human Warrior 4/3 Trample Creatures you control with trample have "You may have this creature assign its combat damage as though it weren't blocked."

Alex-Vasile commented 1 year ago

I've narrowed it down to: https://github.com/magefree/mage/blob/639277402d46f77ff039451cd5b449ef108c22b7/Mage/src/main/java/mage/abilities/effects/ContinuousEffects.java#L1055-L1076

jeffwadsworth commented 10 months ago

https://www.mtgsalvation.com/forums/magic-fundamentals/magic-rulings/magic-rulings-archives/262737-continuous-effect-dependencies-layer-4-and#:~:text=According%20to%20Rule%20418.5d%2C%20the%20dependency%20rule%20is,depend%20on%20it%20or%20not%20depend%20on%20it.

jeffwadsworth commented 10 months ago

A timestamp issue.