magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.87k stars 767 forks source link

Losing the game while in control of a goaded creature causes NPE in multiplayer #9604

Closed Alex-Vasile closed 1 year ago

Alex-Vasile commented 2 years ago

Reported bug from discord.

Opponent casts [[Disrupt decorum]], next turn player attacks another opponent, and the game crashes because of Auto-restored to T29.CD due game error: null

Attached is full game log. (change extension from .txt to .html, GitHub won't let me upload with .html).

20220930_202540_Commander_Free_For_All_1.txt

github-actions[bot] commented 2 years ago

Disrupt Decorum - (Gatherer) (Scryfall) (EDHREC)

{2}{R}{R} Sorcery Goad all creatures you don't control. (Until your next turn, those creatures attack each combat if able and attack a player other than you if able.)

PurpleCrowbar commented 2 years ago

It is a goad issue. It seems like if a player loses the game whilst having goaded creatures under their control and them losing the game doesn't cause the game to end (i.e., at least two other players are still in the game) then the game crashes due to a NPE. I recall reading about this issue, maybe here or on the Discord server

xenohedron commented 1 year ago

Presumably fixed by 22552ed, can reopen if not