Use standard magento config approach

magemojo / m2-ce-cron

Magento 2 cron project to fix bugs and common cron issues.

https://magemojo.com

MIT License

165 stars 45 forks source link

Use standard magento config approach #54

Closed scottsb closed 4 years ago

scottsb commented 6 years ago

Use standard Magento configuration interfaces (both in a UI and OOP sense).

Also fixes these bugs:

Argument order confusion in old configuration getter between $scope and $scopeid (actually worked, but only because MySQL was casting "default" to 0 on both sides of comparison in both where clauses, and 0 == 0)
PHP error when handling exceptions in immediate cron execution command.

Also cleans up inconsistent indention in files I was otherwise touching.

gnuzealot commented 6 years ago

This will have to be reviewed further, there were compatibility issues in magento versions using the standard approach which is why separate functions were made.

scottsb commented 6 years ago

@gnuzealot Do you know what those compatibility issues were? These configuration retrieval methods haven't changed since Magento 2.0, so I'm surprised to hear that.

Also, I see there's a merge conflict now. I can resolve that, but I'll hold off if you think this won't be ready to merge for a while lest more popup later.

gnuzealot commented 6 years ago

I don't recall what versions, but I think it was in 2.0. I'll have to run it through testing and see.

scottsb commented 6 years ago

Magento 2.0 is past end of life. Do you still intend to support it with this extension?

scottsb commented 4 years ago

@gnuzealot I see you closed this without comment, which is obviously your prerogative, but I would appreciate some feedback as to why you didn't want to accept it?