magemonkeystudio / codex

New updated NexEngine
1 stars 10 forks source link

YAML & JSON(Maybe something else) Parser #15

Closed tangjin0418 closed 1 year ago

tangjin0418 commented 1 year ago

image As the code shows, your Parser(s) share a variable i, this will cause issues when async. Please make that parser an Object or do something else.

Like: image

Travja commented 1 year ago

Hmm. Yeah that's interesting. I didn't write the YAMLParser class, but that definitely should be adjusted.

tangjin0418 commented 1 year ago

By the way The YAML parse countSpace should also be changed to: image Otherwise, if the key contains spaces that will be counted too.

tangjin0418 commented 1 year ago

After changing that, might fix this: image