magemonkeystudio / divinity

GNU General Public License v3.0
11 stars 8 forks source link

Added mcMMO, JobsReborn & AureliumSkills Compatibility #186

Closed MaksyKun closed 1 year ago

MaksyKun commented 1 year ago

The PR includes the following in total:

Added Content #40

mcMMO-Compatibility for ItemGenerator #39 :

user-requirements-by-level:
    mcmmo-skill:
          unarmed:
            '1': '1:10'

JobsReborn-Compatibility for ItemGenerator #42 :

user-requirements-by-level:
    jobs-job:
          miner:
            '1': '1:10'

AureliumSkills-Compatibility (Skills + Stats) for ItemGenerator #41 :

user-requirements-by-level:
    aurelium-skill:
          foraging:
            '1': '1:15'
    aurelium-stat:
          strength:
            '1': '1:5'

Changed Content

Remove Changes of Commit 1e60ef5

The sheduler seemed to prevent my build from using the whole ProRPGItems-Command Syntax. Rolling it back lead to the solution, this could however have another reason.

MaksyKun commented 1 year ago

The ingame-editor shall be fixed (at least I tried on local test-server). The JobProgression was null when someone has never touched the job and was fixed aswell. I also added a check at the beginning of an ItemGenerator reload for each extension.

Thanks for your review!

Travja commented 1 year ago

This was not ready to merge.