magemonkeystudio / divinity

GNU General Public License v3.0
9 stars 6 forks source link

[Bug]: Magic Plugin damage miscalculation #201

Open neYaANK opened 6 months ago

neYaANK commented 6 months ago

Is there an existing issue for this?

Current Behavior

Spell deals 9 damage

Expected Behavior

Spell deals 5 damage

Steps To Reproduce

  1. Use Damage in Magic
  2. Set damage value to be 5
  3. Use the spell

Environment

- Server Software: Spigot 1.18.2
- ProRPGItems Version: Tested on both 1.0.6-R0.7 and 1.0.7-R0.2-SNAPSHOT (dev)
- ProMCCore Version: 1.1.0-R0.4
- Plugins:
ProtocolLib:5.0.0,
ProSkillAPI:1.1.13,
ProSkillAPIParties:1.1.0.2,
Magic:10.8.11

latest.log

No response

Anything else?

No response

neYaANK commented 6 months ago

From what I see, the issue may be here https://github.com/promcteam/prorpgitems/blob/927b17fe0331afa3f78136468dc754b8956fcb60/src/main/java/su/nightexpress/quantumrpg/manager/listener/object/VanillaWrapperListener.java#L294C1-L295C1 As after using a spell, wand is not considered as a weapon and damage decreases by 1. In my case, we get 4 damage, that is later added to basic (5) damage and that's where we get 9 damage (5+4). Still, not sure how to handle it

Travja commented 2 months ago

This is damage done via the Magic plugin? Through casting a spell with a stick as a wand?

neYaANK commented 2 months ago

Yep, that's right. Divinity is not used, but installed and affects the damge dealt by Magic. And the wand is stick, yeah.