[Bug]: Plugin cannot handle ProSkillAPI Attributes being disabled

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

If the below config line in ProSkillAPI is set to false, ProRPGItems cannot load any item generators; might need to add a handler for if GetAttributes() returns null or add a comment to the config that these plugins will break.

The below error will be reported in console for each item generator: [12:20:57] [Server thread/WARN]: java.lang.reflect.InvocationTargetException [12:20:57] [Server thread/WARN]: at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) [12:20:57] [Server thread/WARN]: at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) [12:20:57] [Server thread/WARN]: at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) [12:20:57] [Server thread/WARN]: at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) [12:20:57] [Server thread/WARN]: at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480) [12:20:57] [Server thread/WARN]: at prorpgitems-1.0.8-R0.7-20231230.003502-1.jar//su.nightexpress.quantumrpg.modules.api.QModuleDrop.loadItems(QModuleDrop.java:73) [12:20:57] [Server thread/WARN]: at prorpgitems-1.0.8-R0.7-20231230.003502-1.jar//su.nightexpress.quantumrpg.modules.list.itemgenerator.ItemGeneratorManager.loadItems(ItemGeneratorManager.java:147) [12:20:57] [Server thread/WARN]: at prorpgitems-1.0.8-R0.7-20231230.003502-1.jar//su.nightexpress.quantumrpg.modules.api.QModule.onPostSetup(QModule.java:21) [12:20:57] [Server thread/WARN]: at prorpgitems-1.0.8-R0.7-20231230.003502-1.jar//su.nightexpress.quantumrpg.modules.list.itemgenerator.ItemGeneratorManager.onPostSetup(ItemGeneratorManager.java:121) [12:20:57] [Server thread/WARN]: at promccore-1.1.1-R0.4-20231230.003107-1.jar//mc.promcteam.engine.modules.IModule.load(IModule.java:44) [12:20:57] [Server thread/WARN]: at promccore-1.1.1-R0.4-20231230.003107-1.jar//mc.promcteam.engine.modules.ModuleManager.register(ModuleManager.java:67) [12:20:57] [Server thread/WARN]: at prorpgitems-1.0.8-R0.7-20231230.003502-1.jar//su.nightexpress.quantumrpg.modules.ModuleCache.initialize(ModuleCache.java:78) [12:20:57] [Server thread/WARN]: at prorpgitems-1.0.8-R0.7-20231230.003502-1.jar//su.nightexpress.quantumrpg.QuantumRPG.enable(QuantumRPG.java:140) [12:20:57] [Server thread/WARN]: at promccore-1.1.1-R0.4-20231230.003107-1.jar//mc.promcteam.engine.NexPlugin.loadManagers(NexPlugin.java:211) [12:20:57] [Server thread/WARN]: at promccore-1.1.1-R0.4-20231230.003107-1.jar//mc.promcteam.engine.NexPlugin.onEnable(NexPlugin.java:96) [12:20:57] [Server thread/WARN]: at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:281) [12:20:57] [Server thread/WARN]: at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:190) [12:20:57] [Server thread/WARN]: at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:104) [12:20:57] [Server thread/WARN]: at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:507) [12:20:57] [Server thread/WARN]: at org.bukkit.craftbukkit.v1_20_R2.CraftServer.enablePlugin(CraftServer.java:660) [12:20:57] [Server thread/WARN]: at org.bukkit.craftbukkit.v1_20_R2.CraftServer.enablePlugins(CraftServer.java:571) [12:20:57] [Server thread/WARN]: at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:632) [12:20:57] [Server thread/WARN]: at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:429) [12:20:57] [Server thread/WARN]: at net.minecraft.server.dedicated.DedicatedServer.e(DedicatedServer.java:345) [12:20:57] [Server thread/WARN]: at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1102) [12:20:57] [Server thread/WARN]: at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:320) [12:20:57] [Server thread/WARN]: at java.base/java.lang.Thread.run(Thread.java:833) [12:20:57] [Server thread/WARN]: Caused by: java.lang.NullPointerException: Cannot invoke "com.sucy.skill.manager.AttributeManager.getAttributes()" because the return value of "com.sucy.skill.SkillAPI.getAttributeManager()" is null [12:20:57] [Server thread/WARN]: at prorpgitems-1.0.8-R0.7-20231230.003502-1.jar//su.nightexpress.quantumrpg.hooks.external.SkillAPIHK.getAttributes(SkillAPIHK.java:198) [12:20:57] [Server thread/WARN]: at prorpgitems-1.0.8-R0.7-20231230.003502-1.jar//su.nightexpress.quantumrpg.modules.list.itemgenerator.ItemGeneratorManager$GeneratorItem.<init>(ItemGeneratorManager.java:371)

Expected Behavior

No response

Steps To Reproduce

No response

Environment

- Server Software: Purpur 1.20.2 latest
- ProRpgItems Version: 1.0.8-R0.7
- ProMCCore Version: 1.1.1-R0.4
- Plugins: ProSkillAPI, ProRPGItems, ProMCCore

latest.log

No response

Anything else?

No response

magemonkeystudio / divinity