magemonkeystudio / divinity

GNU General Public License v3.0
9 stars 6 forks source link

[Bug]: The drop object illumination function in the itemhints module cannot be applied to drop objects with light purple names. #230

Open Ghost067 opened 3 weeks ago

Ghost067 commented 3 weeks ago

Is there an existing issue for this?

Current Behavior

As the title suggests, the description is very clear.

Expected Behavior

Can make light purple named drops glow normally.

Steps To Reproduce

As the title suggests, the description is very clear.

Environment

- Server Software: PaperSpigot 1.16.5
- Divinity Version: 1.0.0-R0.2-SNAPSHOT
- Codex Version: 1.0.0-R0.3-SNAPSHOT
- Plugins: Divinity Codex

latest.log

[21:53:16 ERROR]: Could not pass event ItemSpawnEvent to Divinity v1.0.0-R0.2-SNAPSHOT java.lang.IllegalArgumentException: Team name 'GLOW_LIGHT_PURPLE' is longer than the limit of 16 characters at org.apache.commons.lang.Validate.isTrue(Validate.java:136) ~[patched_1.16.5.jar:git-Paper-794] at org.bukkit.craftbukkit.v1_16_R3.scoreboard.CraftScoreboard.registerNewTeam(CraftScoreboard.java:201) ~[patched_1.16.5.jar:git-Paper-794] at studio.magemonkey.divinity.modules.list.itemhints.ItemHintsManager.lambda$setGlow$0(ItemHintsManager.java:187) ~[?:?] at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?] at java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1087) ~[?:?] at studio.magemonkey.divinity.modules.list.itemhints.ItemHintsManager.setGlow(ItemHintsManager.java:178) ~[?:?] at studio.magemonkey.divinity.modules.list.itemhints.ItemHintsManager.onItemSpawn(ItemHintsManager.java:124) ~[?:?] at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor874.execute(Unknown Source) ~[?:?] at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.16.5.jar:git-Paper-794] at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.16.5.jar:git-Paper-794] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.16.5.jar:git-Paper-794] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:624) ~[patched_1.16.5.jar:git-Paper-794] at org.bukkit.craftbukkit.v1_16_R3.event.CraftEventFactory.callItemSpawnEvent(CraftEventFactory.java:750) ~[patched_1.16.5.jar:git-Paper-794] at org.bukkit.craftbukkit.v1_16_R3.event.CraftEventFactory.doEntityAddEventCalling(CraftEventFactory.java:642) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.WorldServer.addEntity0(WorldServer.java:1302) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.WorldServer.addEntity(WorldServer.java:1198) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.EntityPlayer.a(EntityPlayer.java:2176) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.EntityHuman.dropItem(EntityHuman.java:640) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.PlayerConnection.a(PlayerConnection.java:1629) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.PacketPlayInBlockDig.a(SourceFile:40) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.PacketPlayInBlockDig.a(SourceFile:10) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.PlayerConnectionUtils.lambda$ensureMainThread$1(PlayerConnectionUtils.java:35) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.TickTask.run(SourceFile:18) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.MinecraftServer.bb(MinecraftServer.java:1271) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.MinecraftServer.executeNext(MinecraftServer.java:1264) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:119) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.MinecraftServer.sleepForTick(MinecraftServer.java:1225) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1139) ~[patched_1.16.5.jar:git-Paper-794] at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:291) ~[patched_1.16.5.jar:git-Paper-794] at java.lang.Thread.run(Thread.java:831) [?:?]

Anything else?

None

Travja commented 3 weeks ago

Ah. 1.16.5. Okay. I'll fix that