magemonkeystudio / divinity

GNU General Public License v3.0
9 stars 6 forks source link

[Bug]: Issue with banned class display #246

Closed goflishMC closed 2 days ago

goflishMC commented 1 week ago

Is there an existing issue for this?

Current Behavior

Banned class and required class showing at the same time as seen here: https://i.imgur.com/50EuiEd.png

Looking at the info below banned class shows up on item level 2-9, even though I have required class set on level 2-9.

Banned class is only set to level 1 item, so the level 2-9 items should only display the required class.

This may or may not be a bug, but we need to make it so that IF required class is set, THEN don't show banned class, because there's no point in showing the banned class if it's already set to the required classes.

  user-requirements-by-level:
    level:
      '1': '1'
      '2': '1'
      '3': '3'
      '4': '5'
      '5': '7'
      '6': '9'
      '7': '11'
      '8': '15'
      '9': '20'
    banned-class:
      '1': Sorcerer,Wizard
    class:
      '2': Fighter,Barbarian,Ranger,Paladin
      '3': Fighter,Barbarian,Ranger,Paladin
      '4': Fighter,Barbarian,Ranger,Paladin
      '5': Fighter
      '6': Fighter
      '7': Fighter
      '8': Fighter
      '9': Fighter

Expected Behavior

This may or may not be a bug, but we need to make it so that IF required class is set, THEN don't show banned class, because there's no point in showing the banned class if it's already set to the required classes.

Steps To Reproduce

copy/paste my class requirements by level above into your itemgenerator.

do /itemgen get common_simple_club 2 1 and you'll see that it shows both banned and required classes.

Environment

- Server Software: 1.20.6 paper
- Divinity Version: 1.0.0 R0.19
- Codex Version: 1.0.0 R0.18
- Plugins: https://i.imgur.com/uOcLTU2.png

latest.log

No response

Anything else?

No response