magemonkeystudio / fabled

Fabled - A skill casting plugin with custom skill builder
https://fabled.magemonkey.studio
MIT License
60 stars 40 forks source link

[Enhancement] Placeholder Rework #1020

Open RAYCAL2000 opened 1 day ago

RAYCAL2000 commented 1 day ago

Placeholder Rework

The following aims to rework and simplify the existing placeholders that the plugin currently has. Some of the placeholders that already exist are redundant and can be removed entirely or reworked. Additionally, the plugin lacks sufficient support for flags and values to be shown or used via PlaceholderAPI.

This rework also aims to add similar functionality that MMOCore has. If a server is using the “ACTION_BAR” mode, there will be an additional set of Placeholders that will allow players to access the names and cooldowns of skills as well as the skills in certain positions.

By default, all Placeholders will link up to the same main class group that is configured in the Config file. For example if you have 'main-class-group': 'class' in your config file, then this will pull information from the class group. For some, you may specify an optional group to get information from that group specifically. For some information such as health, mana, etc. it will take the combined total of all groupings.

Class

Health

Mana

Leveling

Accounts (From Enhancement #991)

Variable Placeholders

These placeholders aim as a way for players to gain access to flags and values outside of just the Fabled plugin. This will make the current variable system much more versatile than it already is.

Skill Placeholders

These placeholders aim to add additional skill information for players to be able to use in other plugins. This will allow players to use them in various HUD plugins such as HappyHUD and BetterHUD to display skill information through them.

funaydmc commented 1 day ago

Can we make it more concise and flexible? For example with %fabled_main_level% We can make it to %fabled_level[_<group>]% [_<group>] is optional, default is main group. The same applies to other placeholders.

RAYCAL2000 commented 1 day ago

Can we make it more concise and flexible?

For example with %fabled_main_level%

We can make it to %fabled_level[_<group>]%

[_<group>] is optional, default is main group.

The same applies to other placeholders.

You know sometimes my brain only half functions, but yeah that seems like a brilliant idea. Let me do a quick rewrite and concise things down later.

RAYCAL2000 commented 2 hours ago

I have gone ahead and finished a second rewrite of the Placeholders, just needs a second pair of eyes before I go ahead and attempt to make it functional.