[Enhancement]: Option to select which DamageCauses to consider with Physical Damage Trigger

[lordsrubka5]

Is there an existing issue for this?

• [X] I have searched the existing issues

Have you tried to reproduce this without OP?

• [X] I have tested without OP

Current Behavior

Physical Damage Trigger Picks up on every Spigot Damage Cause except Custom. I havent checked if Took Physical Damage acts in the same way but it might

Expected Behavior

it should just pick up on Entity Attack, Entity Sweep Attack for melee, Projectile for Ranged or all 3 for both

Steps To Reproduce

-

Environment

-

latest.log

-

Anything else?

No response

[Sentropic]

How about we add an option in the editor where you select which DamageCauses should be considered? Obvs default to all except CUSTOM to not break existing skills.

[lordsrubka5]

damn i dont remember making this one my bad. Yeah im fine with whatever solution you find easiest and fastest to do. All i wanted is to setup different damage causes so that rpgitems combatlog module can pick up on it and display different format holograms.

Out of the topic but do other damage causes still count as damage done from the player? Vanilla minecraft when dropping exp + loot and mythic mobs threat tables care about that a lot

[Sentropic]

Hahah yeah I'll add that selector then.

About the oot: if you mean like when putting "Damage Cause: Fire" in a Damage Mechanic, that'll still count as damage done by the player, but not if you just set them on fire, like with Fire Mechanic. That could actually be fixed.

[lordsrubka5]

I personally dont use fire mechanic but you can add that too if you want to for other people who might use it in the future. Given how no one complained about fire so far it can even be put lower on the todo list perhaps