search

magemonkeystudio / fabled

Fabled - A skill casting plugin with custom skill builder
https://fabled.magemonkey.studio
MIT License
60 stars 40 forks source link

[Enhancement] Skill Bindable Option #777

Open RAYCAL2000 opened 6 months ago

RAYCAL2000 commented 6 months ago

Is your feature request related to a problem? Please describe. Some skills we have are passive and trigger on dealing damage, running, etc. Players are currently able to bind them to their items and it causes headaches as they can activate skills more times then they should be able to.

Describe the solution you'd like Add an option into each individual skill that either marks them passive and prevents them from being binded or just a boolean that allows or prevents a skill from being able to be binded.

Describe alternatives you've considered There are currently no alternatives that exist to this problem that I am aware of.

Additional context None, just let me know if you have any additional questions!

Travja commented 6 months ago

This is mostly in relation to #776? I can see them binding passives to armor and wearing it to get the effects on a different class being a problem. Binding passives from your active class shouldn't be an issue though?

RAYCAL2000 commented 6 months ago

This is mostly in relation to #776? I can see them binding passives to armor and wearing it to get the effects on a different class being a problem. Binding passives from your active class shouldn't be an issue though?

If you have a passive such as dealing damage giving you health back, if they bind that to a weapon it doubles up the effect of a skill.

Also in regards to #776 even if they don't have skills bound they still activate when they shouldn't when a change class occurs. Passives still persist basically.

Travja commented 2 weeks ago

Passives shouldn't persist across changing classes at this point, but there is still likely a need to prevent players from binding some skills to items