magenta / ddsp

DDSP: Differentiable Digital Signal Processing
https://magenta.tensorflow.org/ddsp
Apache License 2.0
2.91k stars 337 forks source link

Fix broken timbre transfer demo notebook + update to ddsp==3.5.0 #479

Closed olaviinha closed 1 year ago

olaviinha commented 1 year ago

Current timbre transfer demo notebook does not work in Colab. According to issue tracker hasn't worked since November 2022.

I see saving from Colab to Github did some minor unintended nugatory changes to character encodings, so...

Notable changes that fix the notebook are:

92: !pip install -qU ddsp==3.5.0 "hmmlearn<=0.2.7"

118: import tensorflow as tf

124: from tensorflow.python.ops.numpy_ops import np_config 125: np_config.enable_numpy_behavior()

347: audio_features_mod = {k: copy.copy(v) for k, v in audio_features.items()}

388: audio_features['loudness_db'].numpy(),

olaviinha commented 1 year ago

Hmm this makes the notebook work but it appears to produce rather poor results, at least with models trained on ddsp[data_preparation]==1.6.3.