magenta / ddsp

DDSP: Differentiable Digital Signal Processing
https://magenta.tensorflow.org/ddsp
Apache License 2.0
2.87k stars 332 forks source link

OnlineF0PowerPreprocessor cannot function with compute_power = False. #494

Open GBroad opened 1 year ago

GBroad commented 1 year ago
def call(self, audio, f0_hz=None, f0_confidence=None, audio_16k=None) -> [
      'f0_hz', 'pw_db', 'f0_scaled', 'pw_scaled', 'f0_confidence']:

Power in decibels (pw_db) cannot be provided in the call definition, which leads to an error as pw_db is used at line 214

https://github.com/magenta/ddsp/blob/b2d180ac6156012fd75316868eb83337b2b83fd0/ddsp/training/preprocessing.py#L214

Leading to an undefined error if compute_power is false.