search

magenta / magenta-js

Magenta.js: Music and Art Generation with Machine Learning in the browser
https://magenta.tensorflow.org
Apache License 2.0
1.96k stars 311 forks source link

Fix audible pops in several soundfont instruments. #657

Closed AmitTzah closed 1 year ago

AmitTzah commented 1 year ago

This pull request fixes a bug that causes audible clicks or pops when playing the FRENCH_HORN or STRING_ENSEMBLE_2 soundfonts (as well as several other soundfonts) in the player demo. The issue is caused by a change in the start() method of the Tone.BufferSource object in newer versions of tone.js, which removed the fifth argument that allowed for the passing of a fadeIn value.

To resolve the issue, this commit adds the missing fadeIn value to releaseSource as a property, ensuring that the sound is properly faded in and out without any clicking or popping.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.