magenta / note-seq

A serializable note sequence representation and utilities.
Apache License 2.0
211 stars 57 forks source link

Why `protobuf >= 4.21.2`? #67

Open bluenote10 opened 2 years ago

bluenote10 commented 2 years ago

Recently the dependency on protobuf has been bumped to >=4.21.2, but apparently without a related code change (at least not in the same commit). I'm wondering why this was necessary?

From what I can see this leads to massive problems with other libraries in the ecosystem. In particular:

Due to the note-seq's requirement of protobuf>=4.21.2 it basically becomes unusable in the tensorflow ecosystem. This doesn't seem to make sense, in particular if nothing obvious has changed in the code? Shouldn't it be much more liberal in the protobuf version to avoid this dependency hell?

czflshzy commented 1 year ago

I meet the same problem

Liujingxiu23 commented 1 year ago

I meet the same problem when pip install. how to fix the problem?

kevinzakka commented 1 year ago

Also having this issue, can this be reverted?