magenta / note-seq

A serializable note sequence representation and utilities.
Apache License 2.0
217 stars 57 forks source link

bokeh compatibility fix #72

Open Yao-Lirong opened 1 year ago

Yao-Lirong commented 1 year ago

Current implementation gives error AttributeError: unexpected attribute 'plot_width' to figure, similar attributes are outer_width, width or min_width when calling notebook_utils.plot_sequence.

As described in this stackoverflow question:

In the 3.0.0 bokeh release, the plot_width attribute of a figure was replaced with width. Similarly, plot_height was replaced with height. Even in the last 2.x.x release docs, they are described as "compatibility aliases" for width and height.

This pull request fixes this issue by following the stackover flow answer mentioned above. Specifically, it

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.