search

magento-ecg / coding-standard

Magento PHP_CodeSniffer Coding Standard
MIT License
308 stars 100 forks source link

Design templates #15

Closed philwinkle closed 9 years ago

philwinkle commented 9 years ago

This doesn't appear to be executing on design templates? Am I missing something?

zlik commented 9 years ago

No templates support yet, sorry.

wojtekn commented 9 years ago

@philwinkle do you mean on .phtml files? I was able to successfully execute sniffer on template files by providing --extensions=php,phtml param to phpcs tool.

However, I extended ECG standard in my custom ruleset file to avoid triggering echo errors in .phtml files:

<rule ref="ecg.Security.LanguageConstruct.DirectOutput">
    <exclude-pattern>*.phtml</exclude-pattern>
</rule>
philwinkle commented 9 years ago

Very nice - exactly what I was looking for!

On Mon, Mar 23, 2015 at 4:20 AM, wojtekn notifications@github.com wrote:

@philwinkle https://github.com/philwinkle do you mean on .phtml files? I was able to successfully execute sniffer on template files by providing --extensions=php,phtml param to phpcs tool.

However, I extended ECG standard in my custom ruleset file to avoid triggering echo errors in .phtml files:

*.phtml

— Reply to this email directly or view it on GitHub https://github.com/magento-ecg/coding-standard/issues/15#issuecomment-84880812 .

Follow me on Twitter - @philwinkle Friend me on Facebook - http://www.facebook.com/philwinkle