search

magento-ecg / coding-standard

Magento PHP_CodeSniffer Coding Standard
MIT License
308 stars 99 forks source link

Extending Zend standard #23

Closed adragus-inviqa closed 9 years ago

adragus-inviqa commented 9 years ago

Hello.

I was thinking that this standard shouldn't be standalone, but extending the Zend one - with <rule ref="Zend"/>.

What do you think?

Zifius commented 9 years ago

That's exactly what I did here: https://github.com/Zifius/Magizendo after discussion in #21

adragus-inviqa commented 9 years ago

Yeah, I was hoping I could avoid that by using just one/this standard. Guess not.

zlik commented 9 years ago

@adragus-inviqa, we want to keep the standard standalone for flexibility. You can create your own ruleset.xml and combine rules from different standards in it as you want, like user @Zifius did.

adragus-inviqa commented 9 years ago

@zlik - Ok, no problem. I understand.

My only beef with this is that, if you check your code with this standard, Zend rules will not be checked. And that would be incorrect. A Magento standard includes a Zend standard (or whatever standard). This repo is not exactly a standard, it's just a grouping of rules.