magento-ecg / coding-standard

Magento PHP_CodeSniffer Coding Standard
MIT License
308 stars 99 forks source link

Warning message for non-plugin class #35

Closed mcspronko closed 2 years ago

mcspronko commented 8 years ago

In case child class extends Magento\Framework\App\Config\Value class with afterSave() method a Warning message is shown: Plugin afterSave function should have at least two parameters.

Note: there is no plugin declaration in di.xml file.

zlik commented 8 years ago

@mcspronko, we'll have someone look into this. Thank you for reporting.

zhooravlik commented 2 years ago

Fixed by commit 561266f. PR#63 created, will be merged to master soon. Closing the issue.