search

magento-ecg / coding-standard

Magento PHP_CodeSniffer Coding Standard
MIT License
308 stars 99 forks source link

Can't use EcgM2 with composer #37

Closed giacmir closed 7 years ago

giacmir commented 8 years ago

I'm using EcgM2 and I tought that it would be nice to add it as a dependency with composer and setup with a custom phpcs.xml so that every one in the team can use it more easily.

But if I add this line in phpcs.xml <rule ref="./vendor/magento-ecg/coding-standard/EcgM2"/>

phpcs dies with this error: PHP Fatal error: Uncaught PHP_CodeSniffer_Exception: Referenced sniff "Ecg.Performance.CollectionCount" does not exist

While if I try to add Ecg it works (but since it is a Magento 2 project I don't need it)

zlik commented 8 years ago

Hi Giacomo,

Thank you for reporting this issue. We'll look into it.

Regards, Alex

philwinkle commented 8 years ago

@AlexanderVekerik still broken 2 months later. Any update??

philwinkle commented 7 years ago

@zlik this should be fixed with #40

siment commented 7 years ago

@zlik Could you please create a release with @philwinkle's change so we can pull package from Packagist?

SantoDE commented 7 years ago

That would be awesome @philwinkle

Zifius commented 7 years ago

@giacmir Are we good to close this issue or there are still problems? EcgM2 depends on Ecg standard so it's not possible to install just M2 version at the moment

@siment FYI releases 2.1 and 3.0 are created

giacmir commented 7 years ago

@Zifius I consider this issue solved for me.

Zifius commented 7 years ago

@giacmir thanks for feedback