search

magento-ecg / coding-standard

Magento PHP_CodeSniffer Coding Standard
MIT License
308 stars 100 forks source link

Shall we folllow the official coding standards? #47

Closed nntoan closed 7 years ago

nntoan commented 7 years ago

Hello,

Magento 2 just published Technical Guidelines and it's pretty cool.

As per as:

2.7. All non-public properties and methods SHOULD be private.

This currently displays a warning with EcgM2, like M1 we warning about private methods and properties.

There are something more, should we improve it to prepare for a better 2.2 release?

P/s: To whom may concern, if you want to make this work. Please follow this pull request: #45

zlik commented 7 years ago

This has been addressed in #45. Thank you, @nntoan!