search

magento-ecg / coding-standard

Magento PHP_CodeSniffer Coding Standard
MIT License
308 stars 99 forks source link

PHPCodeSniffer 3.0 Compatibility #52

Closed Zifius closed 7 years ago

Zifius commented 7 years ago
Zifius commented 7 years ago

@zlik I'd go with the first path, reason is homebrew-php project has 3.0 as mainline version https://github.com/Homebrew/homebrew-php/blob/master/Formula/php-code-sniffer.rb Besides version 3.0.1 of phpcs was released 3 days ago with bugfixes

If phpcs is used as a dependency in composer.json it is easy to pin to 2.x version of phpcs and 2.x version of these coding standards if needed. I'd suggest to create another 2.0.x release before merging this PR (to remove protected properties as a warning)

zlik commented 7 years ago

@Zifius, sounds good. Please merge your PR. Thank you for contributing and for your research!