Allow tablerates csv to be read from non default tmp directory - Githubissues

magento-engcom / import-export-improvements

Open Software License 3.0

31 stars 29 forks source link

Allow tablerates csv to be read from non default tmp directory #106

Closed adam-paterson closed 5 years ago

adam-paterson commented 6 years ago

Description

Allow TableRates csv to be read from none default tmp directory.

Fixed Issues (if relevant)

magento/magento2#10058: Tablerate->getCsvFile() fails with non-default PHP upload_tmp_dir
MAGETWO-70451
84

Manual testing scenarios

Make a new directory for uploads, eg mkdir -p /var/lib/php/uploads && chmod 1777 /var/lib/php/uploads
Set PHP upload_tmp_dir to this directory. eg, add upload_tmp_dir = /var/lib/php/uploads to /etc/php.ini
Login to Magento Admin
Go to Stores > Configuration > Sales > Shipping Methods
Select Table Rates, and enable
Click "Import"
Choose a file, click save.

Contribution checklist

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[x] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds on Travis CI are green)

dmanners commented 5 years ago

Hi @adam-paterson as discussed via slack I will close this PR. For me this fix is already in newer versions of Magento and the release line 2.1 will no longer be available for contribution as of Monday the 17th of September. The decision to close 2.1 was made to increase focus on 2.2 and 2.3 release lines.

Thanks for your understanding.