Allow tablerates csv to be read from non default tmp directory

adam-paterson commented 6 years ago

Description

Allow TableRates csv to be read from none default tmp directory.

Fixed Issues (if relevant)

magento/magento2#10058: Tablerate->getCsvFile() fails with non-default PHP upload_tmp_dir
MAGETWO-70451
84

Manual testing scenarios

Make a new directory for uploads, eg mkdir -p /var/lib/php/uploads && chmod 1777 /var/lib/php/uploads
Set PHP upload_tmp_dir to this directory. eg, add upload_tmp_dir = /var/lib/php/uploads to /etc/php.ini
Login to Magento Admin
Go to Stores > Configuration > Sales > Shipping Methods
Select Table Rates, and enable
Click "Import"
Choose a file, click save.

Contribution checklist

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[x] All new or changed code is covered with unit/integration tests (if applicable)
[x] All automated tests passed successfully (all builds on Travis CI are green)

magento-cicd2 commented 6 years ago

All committers have signed the CLA.

dmanners commented 6 years ago

Seems there is a performance problem at the moment.

Simple product page Fully Loaded Time +6.6% - degradation!

I will take a look at this for you.

dmanners commented 6 years ago

Hi @adam-paterson I am going to close this at the moment as I am not sure why lib/internal/var/generation/Magento/Backend/App/Request/PathInfoProcessor/Proxy.php is also being included in this change. Looking at the original change set this proxy class has no changes.

Feel free to update and reopen this PR if you have the time to look into this change.

Thank you

magento-engcom / import-export-improvements