magento-engcom / import-export-improvements

Open Software License 3.0
31 stars 29 forks source link

MAGETWO-34709 Changing empty label value for first option on dropdown filters. #120

Closed valentinboyanov closed 5 years ago

valentinboyanov commented 5 years ago

Description

We have fixed the "empty" option to allow the user to not select any of the options provided on the dropdown filters.

Fixed Issues

  1. magento-engcom/import-export-improvements#62: [MAGETWO-34709] Export Customers Main File: invalid fields are available in export filter

Manual testing scenarios

  1. Make sure you have sample data to test
  2. Go to System -> Export in Admin panel
  3. Select Customer Main File entity type
  4. Select Female gender in Filter column
  5. Try to drop (remove) this filter to export both genders (without page reload)
  6. Download the file

Contribution checklist

magento-cicd2 commented 5 years ago

CLA assistant check
All committers have signed the CLA.

valentinboyanov commented 5 years ago

Team: @dbolufer @davidselo @valentinboyanov

magento-engcom-team commented 5 years ago

@valentinboyanov thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

dmanners commented 5 years ago

Thank you @valentinboyanov for this pull request. It has now been merged into 2.3-develop.

Great job.