search

magento-engcom / import-export-improvements

Open Software License 3.0
31 stars 29 forks source link

Cleanup History file #122

Closed dmanners closed 5 years ago

dmanners commented 6 years ago

Preconditions (*)

  1. 2.3-develop
  2. phpstan installed composer require --dev phpstan/phpstan

Steps to reproduce (*)

  1. run ./vendor/bin/phpstan analyse -l 0 app/code/Magento/ImportExport/Model/History.php

Expected result (*)

  1. No errors

Actual result (*)

 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------
  Line   History.php
 ------ -------------------------------------------------------------------------------
  66     Access to an undefined property Magento\ImportExport\Model\History::$session.
  313    Access to an undefined property Magento\ImportExport\Model\History::$session.
  314    Access to an undefined property Magento\ImportExport\Model\History::$session.
 ------ -------------------------------------------------------------------------------

 [ERROR] Found 3 errors
dmanners commented 5 years ago

Covered by PR https://github.com/magento-engcom/import-export-improvements/pull/150