search

magento-engcom / import-export-improvements

Open Software License 3.0
31 stars 29 forks source link

Clean up AbstractEntity attributes #124

Closed dmanners closed 5 years ago

dmanners commented 5 years ago

Preconditions (*)

  1. 2.3-develop
  2. phpstan

Steps to reproduce (*)

  1. ./vendor/bin/phpstan analyse -l 0 app/code/Magento/ImportExport/Model/Export/Entity/AbstractEntity.php

Expected result (*)

  1. No errors

Actual result (*)

 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -----------------------------------------------------------------------------------------------------------
  Line   AbstractEntity.php
 ------ -----------------------------------------------------------------------------------------------------------
  178    Access to an undefined property Magento\ImportExport\Model\Export\Entity\AbstractEntity::$_storeIdToCode.
  180    Access to an undefined property Magento\ImportExport\Model\Export\Entity\AbstractEntity::$_storeIdToCode.
  343    Access to an undefined property Magento\ImportExport\Model\Export\Entity\AbstractEntity::$_invalidRows.
  499    Access to an undefined property Magento\ImportExport\Model\Export\Entity\AbstractEntity::$_invalidRows.
 ------ -----------------------------------------------------------------------------------------------------------

 [ERROR] Found 4 errors