search

magento-engcom / import-export-improvements

Open Software License 3.0
31 stars 29 forks source link

Clean Up Magento/ImportExport/Block/Adminhtml/Export/Filter #125

Closed dmanners closed 5 years ago

dmanners commented 5 years ago

Preconditions (*)

  1. 2.3-develop
  2. phpstan installed

Steps to reproduce (*)

  1. ./vendor/bin/phpstan analyse -l 0 app/code/Magento/ImportExport/Block/Adminhtml/Export/Filter.php

Expected result (*)

  1. No errors

Actual result (*)

 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------------------------------
  Line   Filter.php
 ------ -------------------------------------------------------------------------------------------------------
  70     Method Magento\Backend\Block\Widget\Grid::setRowClickCallback() invoked with 1 parameter, 0 required.
 ------ -------------------------------------------------------------------------------------------------------

 [ERROR] Found 1 error