magento-engcom / import-export-improvements

Open Software License 3.0
31 stars 29 forks source link

Does Magento\CatalogImportExport\Model\Import\Uploader need to extend Magento\MediaStorage\Model\File\Uploader? #128

Closed dmanners closed 5 years ago

dmanners commented 6 years ago

Preconditions (*)

  1. Look at Magento\CatalogImportExport\Model\Import\Uploader it extends Magento\MediaStorage\Model\File\Uploader but does not call it's construct method. Question here is does this mean that it should not extend this class?

I would love someone to investigate what exactly we use of any parent classes and report back to see if we would be able to refactor the Uploader class so that it does have have the unneeded dependency.