Closed sagaltsev closed 5 years ago
Question here is should we treat critical errors as a must stop import or can we ignore rows with critical errors?
For the case of configurable products how should this work? If you have an error in the parent product should the childern be imported correctly?
Thanks for the PR @sawebvisum I have run through our static test suite on these changes and it has noted some errors. Could you have a look at them and update this PR.
To setup the code sniffer I recommend running the following from your checkout directory.
./vendor/bin/phpcs --config-set installed_paths dev/tests/static/framework/Magento
- this will install the Magento standard for phpcs (you can check this by running ./vendor/bin/phpcs -i
)
./vendor/bin/phpcs --standard="Magento" app/code/Magento/ImportExport/Controller/Adminhtml/Import/Validate.php
- This will show you the errors for an individual file. I would recommend you run this for each file you have changed.
Thanks
Hi @sawebvisum, thank you for your contribution! Please, complete Contribution Survey, it will take less than a minute. Your feedback will help us to improve contribution process.
Fix stoping on errors so that it uses isErrorLimitExceeded instead of count errors, and include checking critical errors in isErrorLimitExceeded.
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)