magento-engcom/import-export-improvements#75: fix stoping on errors

magento-engcom / import-export-improvements

Open Software License 3.0

31 stars 29 forks source link

magento-engcom/import-export-improvements#75: fix stoping on errors #130

Closed sagaltsev closed 5 years ago

sagaltsev commented 5 years ago

Fix stoping on errors so that it uses isErrorLimitExceeded instead of count errors, and include checking critical errors in isErrorLimitExceeded.

Description (*)

Fixed Issues (if relevant)

magento-engcom/import-export-improvements#75

Manual testing scenarios (*)

Set skip errors on import,
Set limit to 10
Import file with 9 errors,
Message should say file is valid but with 9 errors and the user should be able to import,

Contribution checklist (*)

[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds on Travis CI are green)

magento-cicd2 commented 5 years ago

All committers have signed the CLA.

sagaltsev commented 5 years ago

Question here is should we treat critical errors as a must stop import or can we ignore rows with critical errors?

For the case of configurable products how should this work? If you have an error in the parent product should the childern be imported correctly?

dmanners commented 5 years ago

Thanks for the PR @sawebvisum I have run through our static test suite on these changes and it has noted some errors. Could you have a look at them and update this PR.

To setup the code sniffer I recommend running the following from your checkout directory.

./vendor/bin/phpcs --config-set installed_paths dev/tests/static/framework/Magento - this will install the Magento standard for phpcs (you can check this by running ./vendor/bin/phpcs -i) ./vendor/bin/phpcs --standard="Magento" app/code/Magento/ImportExport/Controller/Adminhtml/Import/Validate.php - This will show you the errors for an individual file. I would recommend you run this for each file you have changed.

Thanks

ghost commented 5 years ago

Hi @sawebvisum, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.