magento-engcom / import-export-improvements

Open Software License 3.0
31 stars 29 forks source link

Clean Up Test/Unit/Model/Import/Product/Type/ConfigurableTest.php #131

Closed dmanners closed 5 years ago

dmanners commented 6 years ago

Preconditions (*)

  1. 2.3-develop
  2. phpstan installed

Steps to reproduce (*)

  1. Run ./vendor/bin/phpstan analyse app/code/Magento/ConfigurableImportExport/Test/Unit/Model/Import/Product/Type/ConfigurableTest.php

Expected result (*)

  1. No Errors

Actual result (*)

 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------------------------------------------------------------------------
  Line   ConfigurableTest.php
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------
  401    Array has 2 duplicate keys with value 'is_static' ('is_static', 'is_static').
  423    Array has 2 duplicate keys with value 'is_static' ('is_static', 'is_static').
  611    Access to an undefined property Magento\ConfigurableImportExport\Test\Unit\Model\Import\Product\Type\ConfigurableTest::$_oldSku.
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------

 [ERROR] Found 3 errors