search

magento-engcom / import-export-improvements

Open Software License 3.0
31 stars 29 forks source link

Clean up Model/Import/Address.php #136

Closed dmanners closed 5 years ago

dmanners commented 5 years ago

Preconditions (*)

  1. 2.3-develop
  2. PHPStan installed

Steps to reproduce (*)

  1. Run ./vendor/bin/phpstan analyse app/code/Magento/CustomerImportExport/Model/Import/Address.php

Expected result (*)

  1. No errors

Actual result (*)

 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   Address.php
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  318    Access to an undefined property Magento\CustomerImportExport\Model\Import\Address::$_regionCollection.
  431    Access to an undefined property Magento\CustomerImportExport\Model\Import\Address::$_regionCollection.
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------

 [ERROR] Found 2 errors
dmanners commented 5 years ago

Thanks for this PR. This has now been merged into 2.3-develop.