search

magento-engcom / import-export-improvements

Open Software License 3.0
31 stars 29 forks source link

Clean Up Helper/Uploader.php #137

Closed dmanners closed 5 years ago

dmanners commented 5 years ago

Preconditions (*)

  1. 2.3-develop
  2. PHPStan installed

Steps to reproduce (*)

  1. Run ./vendor/bin/phpstan analyse app/code/Magento/DownloadableImportExport/Helper/Uploader.php

Expected result (*)

  1. No Errors

Actual result (*)

 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------------------------------------------------------------------
  Line   Uploader.php
 ------ --------------------------------------------------------------------------------------------------------------------------------
  63     Access to an undefined property Magento\DownloadableImportExport\Helper\Uploader::$connection.
 ------ --------------------------------------------------------------------------------------------------------------------------------

 [ERROR] Found 1 error