magento-engcom / import-export-improvements

Open Software License 3.0
31 stars 29 forks source link

Added $_regionCollection property to class #140

Closed maxalmonte14 closed 5 years ago

maxalmonte14 commented 5 years ago

Description (*)

This PR fixes an error detected by PHPStan

Fixed Issues (if relevant)

  1. https://github.com/magento-engcom/import-export-improvements/issues/136: Clean up Model/Import/Address.php

Manual testing scenarios (*)

  1. Run ./vendor/bin/phpstan analyse app/code/Magento/CustomerImportExport/Model/Import/Address.php as described in https://github.com/magento-engcom/import-export-improvements/issues/136, after this implementation the following errors shouldn't be present
------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   Address.php
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  318    Access to an undefined property Magento\CustomerImportExport\Model\Import\Address::$_regionCollection.
  431    Access to an undefined property Magento\CustomerImportExport\Model\Import\Address::$_regionCollection.
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Contribution checklist (*)

magento-cicd2 commented 5 years ago

CLA assistant check
All committers have signed the CLA.

maxalmonte14 commented 5 years ago

@dmanners thanks for the feedback, I'll apply the changes as soon as possible. ✌️

maxalmonte14 commented 5 years ago

Updated, rookie mistake in the docblock 😅